elbv2 - Fix load balancer listener comparison #2377

ichekaldin · 2024-11-05T20:02:00Z

SUMMARY

Fixes #2376.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

elbv2
elb_application_lb

ADDITIONAL INFORMATION

softwarefactory-project-zuul · 2024-11-05T20:51:15Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/63dcde26c8c94e308286bd31722c4d79

✔️ ansible-galaxy-importer SUCCESS in 5m 25s
✔️ build-ansible-collection SUCCESS in 10m 10s
✔️ ansible-test-splitter SUCCESS in 3m 55s
✔️ integration-amazon.aws-1 SUCCESS in 12m 55s
✔️ integration-community.aws-1 SUCCESS in 18m 49s
Skipped 42 jobs

mandar242 · 2024-11-12T23:35:39Z

tests/integration/targets/elb_application_lb/tasks/main.yml

+                  MessageBody: Not available
+                  StatusCode: "404"
+      register: alb
+      check_mode: true


Suggested change

check_mode: true

check_mode: true

mandar242 · 2024-11-12T23:37:00Z

tests/integration/targets/elb_application_lb/tasks/main.yml

+                  StatusCode: "404"
+      register: alb
+      check_mode: true
+    - ansible.builtin.assert:


Suggested change

- ansible.builtin.assert:

- name: Assert check_mode result

ansible.builtin.assert:

mandar242 · 2024-11-12T23:37:44Z

tests/integration/targets/elb_application_lb/tasks/main.yml

+                  MessageBody: Not available
+                  StatusCode: "404"
+      register: alb
+    - ansible.builtin.assert:


Suggested change

- ansible.builtin.assert:

- name: Assert update ALB result

ansible.builtin.assert:

mandar242 · 2024-11-12T23:38:11Z

tests/integration/targets/elb_application_lb/tasks/main.yml

+                  StatusCode: "404"
+      register: alb
+      check_mode: true
+    - ansible.builtin.assert:


Suggested change

- ansible.builtin.assert:

- name: Assert check_mode idempotence result

ansible.builtin.assert:

mandar242 · 2024-11-12T23:38:34Z

tests/integration/targets/elb_application_lb/tasks/main.yml

+                  MessageBody: Not available
+                  StatusCode: "404"
+      register: alb
+    - ansible.builtin.assert:


Suggested change

- ansible.builtin.assert:

- name: Assert idempotence result

ansible.builtin.assert:

mandar242

Overall lgtm! Thanks for contribution @ichekaldin

ichekaldin · 2024-11-13T00:26:46Z

Overall lgtm! Thanks for contribution @ichekaldin

Thank you! I added the suggested changes.

softwarefactory-project-zuul · 2024-11-13T01:04:22Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/be67d7910874406d8f35d21bd4c26b30

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 10m 01s
✔️ ansible-test-splitter SUCCESS in 4m 11s
✔️ integration-amazon.aws-1 SUCCESS in 9m 59s
✔️ integration-community.aws-1 SUCCESS in 18m 44s
Skipped 42 jobs

fabricat-mdb · 2024-11-15T14:30:32Z

Bug #2376 is blocking me.
How can we facilitate this PR?

fabricat-mdb · 2024-11-22T11:27:38Z

The modified code is not working for me.
The partial stack trace of the module failure is:

  File "..../ansible_amazon.aws.elb_application_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/elb_application_lb.py", line 860, in create_or_update_alb
  File "..../ansible_amazon.aws.elb_application_lb_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/elbv2.py", line 933, in compare_listeners
  File "..../ansible_amazon.aws.elb_application_lb_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/elbv2.py", line 865, in _group_listeners
  File "..../ansible_amazon.aws.elb_application_lb_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/elbv2.py", line 807, in _compare_listener
  File "..../ansible_amazon.aws.elb_application_lb_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/elbv2.py", line 163, in _sort_listener_actions
TypeError: '<' not supported between instances of 'NoneType' and 'dict'

I really need this bug to be fixed, so (even if I'm not a Python coder) I struggled a bit to debug this.
Maybe one of the problems is that AuthenticateOidcConfig, FixedResponseConfig, and RedirectConfig are dictionaries, while _sort_listener_actions signature expects strings (actions: List[Dict[str, str]]))?

As an alternative, is it possible to use _sort_actions instead of _sort_listener_actions?
It simply uses Order as the sorting key. I noticed that Order is always present in current_listener (and is required in module parameters) when the listener has more than one default action.
When there is only one default action, sorting is not needed.

softwarefactory-project-zuul · 2024-11-29T17:43:06Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e52323dc38e74dbf841fc648f99f259f

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 10m 22s
✔️ ansible-test-splitter SUCCESS in 4m 23s
✔️ integration-amazon.aws-1 SUCCESS in 12m 23s
✔️ integration-community.aws-1 SUCCESS in 16m 56s
Skipped 42 jobs

github-actions · 2024-11-29T17:46:16Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

patchback · 2024-12-02T10:11:37Z

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/bb3914afb8e125c896ac6e8e3ff8d025604b9c78/pr-2377

Backported as #2403

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

SUMMARY Fixes #2376. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elbv2 elb_application_lb ADDITIONAL INFORMATION Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin (cherry picked from commit bb3914a)

This is a backport of PR #2377 as merged into main (bb3914a). SUMMARY Fixes #2376. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elbv2 elb_application_lb ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

mandar242 reviewed Nov 12, 2024

View reviewed changes

mandar242 approved these changes Nov 12, 2024

View reviewed changes

ichekaldin added 4 commits November 12, 2024 19:34

Fix load balancer listener comparison

77cfeff

Fix formatting

1dd1dc0

Add integration tests

abe8899

Implement suggested changes

9718600

ichekaldin force-pushed the elb_application_lb-fix-listener-comparison branch from 8351e26 to 9718600 Compare November 13, 2024 00:34

fabricat-mdb mentioned this pull request Nov 25, 2024

elb_application_lb - Module fails if listener default action is anything other than Forward #2376

Closed

1 task

abikouo approved these changes Nov 29, 2024

View reviewed changes

abikouo added the mergeit Merge the PR (SoftwareFactory) label Nov 29, 2024

softwarefactory-project-zuul bot merged commit bb3914a into ansible-collections:main Nov 29, 2024
45 checks passed

ichekaldin deleted the elb_application_lb-fix-listener-comparison branch December 1, 2024 04:48

alinabuzachis added the backport-9 label Dec 2, 2024

patchback bot mentioned this pull request Dec 2, 2024

[PR #2377/bb3914af backport][stable-9] elbv2 - Fix load balancer listener comparison #2403

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

elbv2 - Fix load balancer listener comparison #2377

elbv2 - Fix load balancer listener comparison #2377

ichekaldin commented Nov 5, 2024

softwarefactory-project-zuul bot commented Nov 5, 2024

mandar242 Nov 12, 2024

mandar242 Nov 12, 2024

mandar242 Nov 12, 2024

mandar242 Nov 12, 2024

mandar242 Nov 12, 2024

mandar242 left a comment •

edited

Loading

ichekaldin commented Nov 13, 2024

softwarefactory-project-zuul bot commented Nov 13, 2024

fabricat-mdb commented Nov 15, 2024

fabricat-mdb commented Nov 22, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

patchback bot commented Dec 2, 2024 •

edited

Loading

	- ansible.builtin.assert:
	- name: Assert check_mode result
	ansible.builtin.assert:

elbv2 - Fix load balancer listener comparison #2377

elbv2 - Fix load balancer listener comparison #2377

Conversation

ichekaldin commented Nov 5, 2024

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Nov 5, 2024

mandar242 Nov 12, 2024

Choose a reason for hiding this comment

mandar242 Nov 12, 2024

Choose a reason for hiding this comment

mandar242 Nov 12, 2024

Choose a reason for hiding this comment

mandar242 Nov 12, 2024

Choose a reason for hiding this comment

mandar242 Nov 12, 2024

Choose a reason for hiding this comment

mandar242 left a comment • edited Loading

Choose a reason for hiding this comment

ichekaldin commented Nov 13, 2024

softwarefactory-project-zuul bot commented Nov 13, 2024

fabricat-mdb commented Nov 15, 2024

fabricat-mdb commented Nov 22, 2024 • edited Loading

softwarefactory-project-zuul bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

Docs Build 📝

patchback bot commented Dec 2, 2024 • edited Loading

Backport to stable-9: 💚 backport PR created

mandar242 left a comment •

edited

Loading

fabricat-mdb commented Nov 22, 2024 •

edited

Loading

patchback bot commented Dec 2, 2024 •

edited

Loading