ec2_vpc_route_table: Add support to configure Transit Gateway routes in route table #2291
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 41s |
alinabuzachis
added
the
backport-8
| - dest: 0.0.0.0/0 | ||
| gateway_id: "{{ transit_gateway_id }}" |
There was a problem hiding this comment.
| - dest: 0.0.0.0/0 | |
| gateway_id: "{{ transit_gateway_id }}" | |
| - dest: 0.0.0.0/0 | |
| gateway_id: "{{ transit_gateway_id }}" | |
| - dest: 1.1.1.1/0 | |
| transit_gateway_id: "{{ transit_gateway_id }}" |
There was a problem hiding this comment.
1.1.1.1/0 is (sort-of) the same as 0.0.0.0/0
I'd recommend 192.0.2.0/24 (TEST-NET-1) as the second example dest instead.
| - Routes are specified as dicts containing the keys V(dest) and one of V(gateway_id), | ||
| V(instance_id), V(network_interface_id), or V(vpc_peering_connection_id). | ||
| V(instance_id), V(network_interface_id), V(transit_gateway_id), or V(vpc_peering_connection_id). |
There was a problem hiding this comment.
This looks like we might have actually supported this before (if you knew the undocumented key to add here).
Is it worth modifying the arg_spec definition to only accept "good" values?
There was a problem hiding this comment.
I think adding choices with specified values would be best. By doing so, we could add this PR to version 9.0.0, as it might be a breaking change. Am I right? cc @alinabuzachis
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 24s |
softwarefactory-project-zuul
bot
merged commit 14d447b
into
ansible-collections:main
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2295 🤖 @patchback |
… in route table (#2291) SUMMARY Fixes #478 This PR updates the ec2_vpc_route_table "routes" parameter to support the transit gateway id. ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Mark Chappell Reviewed-by: GomathiselviS (cherry picked from commit 14d447b)
… in route table (ansible-collections#2291) SUMMARY Fixes ansible-collections#478 This PR updates the ec2_vpc_route_table "routes" parameter to support the transit gateway id. ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Mark Chappell Reviewed-by: GomathiselviS
… in route table (#2291) (#2295) This is a backport of PR #2291 as merged into main (14d447b). SUMMARY Fixes #478 This PR updates the ec2_vpc_route_table "routes" parameter to support the transit gateway id. ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
SUMMARY
Fixes #478
This PR updates the ec2_vpc_route_table "routes" parameter to support the transit gateway id.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION