Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #2209/5756ac43 backport][stable-8] Add option "metadata_token_ttl_seconds" to ec2_metadata_facts module. #2210

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 5, 2024

This is a backport of PR #2209 as merged into main (5756ac4).

Fixes: #2205

SUMMARY

ec2_metadata_facts sometimes returns 401 unauthorized if the IMDSv2 token times out. The token TTL is currently hardcoded to 60, this pull request aims to make it configurable.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_metadata_facts

…#2209)

Fixes: #2205
SUMMARY
ec2_metadata_facts sometimes returns 401 unauthorized if the IMDSv2 token times out. The token TTL is currently hardcoded to 60, this pull request aims to make it configurable.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_metadata_facts

Reviewed-by: Mark Chappell
(cherry picked from commit 5756ac4)
Copy link

github-actions bot commented Aug 5, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/287c1520aaa14e7a9d2f2f66fe0a78d9

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 10m 27s
✔️ ansible-test-splitter SUCCESS in 4m 14s
integration-amazon.aws-1 FAILURE in 12m 18s
Skipped 43 jobs

@tremble
Copy link
Contributor

tremble commented Aug 5, 2024

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e939a0213a5b4f7d9723df83f6fc7f33

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 10m 21s
✔️ ansible-test-splitter SUCCESS in 4m 16s
integration-amazon.aws-1 FAILURE in 12m 11s
Skipped 43 jobs

@alinabuzachis
Copy link
Collaborator

recheck

@alinabuzachis alinabuzachis added this to the 8.2.0 milestone Aug 22, 2024
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/295bd7cba23c4cbeb832251b84935161

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 11m 05s
✔️ ansible-test-splitter SUCCESS in 4m 34s
integration-amazon.aws-1 FAILURE in 10m 26s
Skipped 43 jobs

@tremble
Copy link
Contributor

tremble commented Aug 28, 2024

recheck

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 28, 2024
Copy link
Contributor

This change depends on a change that failed to merge.

Change #2258 is needed.

@tremble tremble added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Aug 28, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a4cda55bec8140b9be1d4714d58cadd6

✔️ ansible-galaxy-importer SUCCESS in 5m 09s
✔️ build-ansible-collection SUCCESS in 10m 31s
✔️ ansible-test-splitter SUCCESS in 4m 17s
✔️ integration-amazon.aws-1 SUCCESS in 8m 55s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f5f3bc5 into stable-8 Aug 28, 2024
37 of 39 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-8/5756ac437c79393c009d99df71d9ded95dd6be84/pr-2209 branch August 28, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants