-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ec2_vol* modules #2170
Merged
softwarefactory-project-zuul
merged 3 commits into
ansible-collections:main
from
abikouo:refactor-modules-ec2_vol-2401071447
Jul 8, 2024
Merged
Refactor ec2_vol* modules #2170
softwarefactory-project-zuul
merged 3 commits into
ansible-collections:main
from
abikouo:refactor-modules-ec2_vol-2401071447
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
force-pushed
the
refactor-modules-ec2_vol-2401071447
branch
from
July 2, 2024 15:29
530f580
to
a960c25
Compare
hakbailey
approved these changes
Jul 6, 2024
alinabuzachis
approved these changes
Jul 8, 2024
abikouo
force-pushed
the
refactor-modules-ec2_vol-2401071447
branch
from
July 8, 2024 13:14
a960c25
to
59707c8
Compare
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 01s |
softwarefactory-project-zuul
bot
merged commit Jul 8, 2024
08ce730
into
ansible-collections:main
33 of 37 checks passed
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 21, 2024
…ollections#2163)" (ansible-collections#2170) This reverts commit 7f11acb. Reverts ansible-collections#2163 ansible-collections#2163 changes are being reverted as it has been agreed to hold off on merging the migration PRs until a plan is set to migrate all planned modules at once. We need to disable the squash strategy in github first to retain commit history. SUMMARY Reviewed-by: GomathiselviS This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4cf5a6f
mandar242
added a commit
to mandar242/amazon.aws
that referenced
this pull request
Oct 21, 2024
…ollections#2163)" (ansible-collections#2170) This reverts commit 7f11acb. Reverts ansible-collections#2163 ansible-collections#2163 changes are being reverted as it has been agreed to hold off on merging the migration PRs until a plan is set to migrate all planned modules at once. We need to disable the squash strategy in github first to retain commit history. SUMMARY Reviewed-by: GomathiselviS This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4cf5a6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Refactor ec2_vol, ec2_vol_info modules
ISSUE TYPE
COMPONENT NAME