Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests - Replace use of db.t2 instance class #2141

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Tests - Replace use of db.t2 instance class #2141

merged 2 commits into from
Jun 25, 2024

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 24, 2024

SUMMARY

Amazon's dropping support for M4/R4/T2 RDS DB instances, replace their use in tests before something suddenly fails.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds

ADDITIONAL INFORMATION

alinabuzachis
alinabuzachis reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tremble How about updating any samples and EXAMPLES blocks in the rds_instance and rds_instane_info modules as well?

@tremble
Copy link
Contributor Author

tremble commented Jun 24, 2024

@tremble How about updating any samples and EXAMPLES blocks in the rds_instance and rds_instane_info modules as well?

Was more interested in making sure tests didn't break so didn't think about the docs :) Done

@tremble tremble requested a review from alinabuzachis June 24, 2024 13:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble added mergeit Merge the PR (SoftwareFactory) backport-7 PR should be backported to the stable-7 branch backport-8 PR should be backported to the stable-8 branch labels Jun 25, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/919995b5be27479592e01c10f08b9e03

✔️ ansible-galaxy-importer SUCCESS in 3m 21s
✔️ build-ansible-collection SUCCESS in 12m 21s
✔️ ansible-test-splitter SUCCESS in 4m 56s
✔️ integration-amazon.aws-1 SUCCESS in 16m 44s
✔️ integration-amazon.aws-2 SUCCESS in 32m 25s
✔️ integration-amazon.aws-3 SUCCESS in 38m 18s
✔️ integration-amazon.aws-4 SUCCESS in 21m 50s
✔️ integration-amazon.aws-5 SUCCESS in 19m 37s
✔️ integration-amazon.aws-6 SUCCESS in 14m 48s
✔️ integration-amazon.aws-7 SUCCESS in 22m 15s
✔️ integration-amazon.aws-8 SUCCESS in 20m 48s
✔️ integration-amazon.aws-9 SUCCESS in 16m 37s
✔️ integration-amazon.aws-10 SUCCESS in 22m 47s
✔️ integration-amazon.aws-11 SUCCESS in 12m 42s
✔️ integration-amazon.aws-12 SUCCESS in 8m 59s
✔️ integration-amazon.aws-13 SUCCESS in 6m 31s
Skipped 31 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Required status check "ansible/gate" is expected.

tremble added 2 commits June 25, 2024 17:05
@tremble
Tests - Replace use of db.t2 instance class
c7a0690 
Amazon's dropping support for M4/R4/T2 RDS DB instances, replace their use in tests before something suddenly fails.
@tremble
docs
f11ce3f
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7008e3c611db46d292fb80e354402969

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 12m 20s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-amazon.aws-1 SUCCESS in 14m 59s
✔️ integration-amazon.aws-2 SUCCESS in 29m 27s
✔️ integration-amazon.aws-3 SUCCESS in 35m 15s
✔️ integration-amazon.aws-4 SUCCESS in 23m 51s
✔️ integration-amazon.aws-5 SUCCESS in 20m 03s
✔️ integration-amazon.aws-6 SUCCESS in 14m 45s
✔️ integration-amazon.aws-7 SUCCESS in 22m 30s
✔️ integration-amazon.aws-8 SUCCESS in 26m 09s
✔️ integration-amazon.aws-9 SUCCESS in 16m 34s
✔️ integration-amazon.aws-10 SUCCESS in 22m 55s
✔️ integration-amazon.aws-11 SUCCESS in 13m 41s
✔️ integration-amazon.aws-12 SUCCESS in 10m 46s
✔️ integration-amazon.aws-13 SUCCESS in 9m 10s
Skipped 31 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/ca52a529f86f4669a07083bb9480d62a

✔️ ansible-galaxy-importer SUCCESS in 8m 33s
✔️ build-ansible-collection SUCCESS in 12m 23s
✔️ ansible-test-splitter SUCCESS in 4m 51s
✔️ integration-amazon.aws-1 SUCCESS in 13m 56s
✔️ integration-amazon.aws-2 SUCCESS in 32m 06s
✔️ integration-amazon.aws-3 SUCCESS in 33m 09s
✔️ integration-amazon.aws-4 SUCCESS in 24m 48s
✔️ integration-amazon.aws-5 SUCCESS in 21m 38s
✔️ integration-amazon.aws-6 SUCCESS in 14m 47s
✔️ integration-amazon.aws-7 SUCCESS in 24m 25s
✔️ integration-amazon.aws-8 SUCCESS in 23m 11s
✔️ integration-amazon.aws-9 SUCCESS in 16m 23s
✔️ integration-amazon.aws-10 SUCCESS in 22m 20s
✔️ integration-amazon.aws-11 SUCCESS in 17m 09s
✔️ integration-amazon.aws-12 SUCCESS in 11m 09s
✔️ integration-amazon.aws-13 SUCCESS in 6m 28s
Skipped 31 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 52d3965 into ansible-collections:main Jun 25, 2024
36 checks passed
@patchback Patchback
Copy link

patchback bot commented Jun 25, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/52d3965188d45841495c1721aaf1615d08d6874d/pr-2141

Backported as #2147

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 25, 2024
@tremble @patchback
Tests - Replace use of db.t2 instance class (#2141)
ec40e4f 
SUMMARY
Amazon's dropping support for M4/R4/T2 RDS DB instances, replace their use in tests before something suddenly fails.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
rds
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 52d3965)
@patchback patchback bot mentioned this pull request Jun 25, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Jun 25, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/52d3965188d45841495c1721aaf1615d08d6874d/pr-2141

Backported as #2148

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 25, 2024
@tremble @patchback
Tests - Replace use of db.t2 instance class (#2141)
0b17297 
SUMMARY
Amazon's dropping support for M4/R4/T2 RDS DB instances, replace their use in tests before something suddenly fails.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
rds
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 52d3965)
@patchback patchback bot mentioned this pull request Jun 25, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 25, 2024
@patchback
Tests - Replace use of db.t2 instance class (#2141) (#2147)
6ef75f2 
This is a backport of PR #2141 as merged into main (52d3965).
SUMMARY
Amazon's dropping support for M4/R4/T2 RDS DB instances, replace their use in tests before something suddenly fails.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
rds
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 25, 2024
@patchback
Tests - Replace use of db.t2 instance class (#2141) (#2148)
ac1098a 
This is a backport of PR #2141 as merged into main (52d3965).
SUMMARY
Amazon's dropping support for M4/R4/T2 RDS DB instances, replace their use in tests before something suddenly fails.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
rds
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Jun 26, 2024
@tremble @alinabuzachis
Tests - Replace use of db.t2 instance class (ansible-collections#2141)
6647b3d 
SUMMARY
Amazon's dropping support for M4/R4/T2 RDS DB instances, replace their use in tests before something suddenly fails.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
rds
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-7 PR should be backported to the stable-7 branch backport-8 PR should be backported to the stable-8 branch mergeit Merge the PR (SoftwareFactory) skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @alinabuzachis