Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity test / doc-default-does-not-match-spec fixups #214

Merged
merged 4 commits into from
Dec 6, 2020

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Dec 5, 2020

SUMMARY

Daily run picked up the following:

plugins/modules/aws_s3.py:0:0: doc-default-does-not-match-spec: Argument 'ignore_nonexistent_bucket' in argument_spec defines default as (False) but documentation defines default as (None)
plugins/modules/ec2.py:0:0: doc-default-does-not-match-spec: Argument 'termination_protection' in argument_spec defines default as (None) but documentation defines default as (False)
plugins/modules/ec2_elb_lb.py:0:0: doc-default-does-not-match-spec: Argument 'cross_az_load_balancing' in argument_spec defines default as (None) but documentation defines default as (False)
plugins/modules/ec2_vpc_dhcp_option_info.py:0:0: doc-default-does-not-match-spec: Argument 'dry_run' in argument_spec defines default as (False) but documentation defines default as (None)
plugins/modules/s3_bucket.py:0:0: doc-default-does-not-match-spec: Argument 'ceph' in argument_spec defines default as (False) but documentation defines default as (None)

Some additional doc-style fixups.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/modules/aws_s3.py
plugins/modules/ec2.py
plugins/modules/ec2_elb_lb.py
plugins/modules/ec2_vpc_dhcp_option_info.py
plugins/modules/s3_bucket.py

ADDITIONAL INFORMATION

Fallout from ansible/ansible#72699

@tremble tremble requested review from jillr and felixfontein December 5, 2020 19:31
plugins/modules/aws_s3.py Outdated Show resolved Hide resolved
plugins/modules/ec2.py Outdated Show resolved Hide resolved
plugins/modules/ec2.py Outdated Show resolved Hide resolved
@tremble tremble requested a review from felixfontein December 6, 2020 07:33
@felixfontein felixfontein merged commit 38ac73f into ansible-collections:main Dec 6, 2020
jillr pushed a commit to jillr/amazon.aws that referenced this pull request May 3, 2021
…roup_ids_from_names (ansible-collections#214)

* ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names

* changelog
jillr pushed a commit to jillr/amazon.aws that referenced this pull request May 10, 2021
…roup_ids_from_names (ansible-collections#214)

* ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names

* changelog
jillr pushed a commit to jillr/amazon.aws that referenced this pull request May 10, 2021
…roup_ids_from_names (ansible-collections#214)

* ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names

* changelog
jillr pushed a commit to jillr/amazon.aws that referenced this pull request May 13, 2021
…roup_ids_from_names (ansible-collections#214)

* ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names

* changelog
@tremble tremble deleted the sanity/doc-default branch May 28, 2021 07:09
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…roup_ids_from_names (ansible-collections#214)

* ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…roup_ids_from_names (ansible-collections#214)

* ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…roup_ids_from_names (ansible-collections#214)

* ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants