Update return block - s3_bucket, s3_bucket_info, s3_object #2135
Patchback / Backport to stable-8
completed
Aug 27, 2024 in 7s
Backport to stable-8: 💔 cherry-picking failed — conflicts found
❌ Failed to cleanly apply 34e3954 on top of patchback/backports/stable-8/34e3954496d43ab76ae0192b795dc6380c8db804/pr-2135
Details
Backporting merged PR #2135 into main
- Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be yourorigin
remote. - Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the nameupstream
. If you don't
have it, here's how you can add it:$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
- Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:$ git fetch upstream $ git checkout -b patchback/backports/stable-8/34e3954496d43ab76ae0192b795dc6380c8db804/pr-2135 upstream/stable-8
- Now, cherry-pick PR #2135 contents into that branch:
If it'll yell at you with something like
$ git cherry-pick -x 34e3954496d43ab76ae0192b795dc6380c8db804
fatal: Commit 34e3954496d43ab76ae0192b795dc6380c8db804 is a merge but no -m option was given.
, add-m 1
as follows instead:$ git cherry-pick -m1 -x 34e3954496d43ab76ae0192b795dc6380c8db804
- At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR #2135 as close to the
original as possible. - Push this branch to your fork on GitHub:
$ git push origin patchback/backports/stable-8/34e3954496d43ab76ae0192b795dc6380c8db804/pr-2135
- Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!
Loading