-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #1979/0d1a604b backport][stable-8] Don't ignore IPv6 addresses when a single network interface is specified #2113
Merged
gravesm
merged 1 commit into
stable-8
from
patchback/backports/stable-8/0d1a604b9aaa1c4e35274eaf3ebfe97fdd5fd00c/pr-1979
Jun 4, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied (#1979) Don't ignore IPv6 addresses when a single network interface is specified SUMMARY When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 0d1a604)
alinabuzachis
approved these changes
Jun 4, 2024
regate |
gravesm
deleted the
patchback/backports/stable-8/0d1a604b9aaa1c4e35274eaf3ebfe97fdd5fd00c/pr-1979
branch
June 4, 2024 15:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1979 as merged into main (0d1a604).
SUMMARY
When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour.
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION