Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1979/0d1a604b backport][stable-8] Don't ignore IPv6 addresses when a single network interface is specified #2113

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 24, 2024

This is a backport of PR #1979 as merged into main (0d1a604).

SUMMARY

When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

…ied (#1979)

Don't ignore IPv6 addresses when a single network interface is specified

SUMMARY

When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
(cherry picked from commit 0d1a604)
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2993e45f1ecf49b3a43b0ae27bb60315

✔️ ansible-galaxy-importer SUCCESS in 5m 22s
✔️ build-ansible-collection SUCCESS in 15m 53s
✔️ ansible-test-splitter SUCCESS in 7m 05s
✔️ integration-amazon.aws-1 SUCCESS in 27m 57s
✔️ integration-amazon.aws-2 SUCCESS in 19m 24s
✔️ integration-amazon.aws-3 SUCCESS in 9m 50s
✔️ integration-amazon.aws-4 SUCCESS in 11m 00s
✔️ integration-amazon.aws-5 SUCCESS in 12m 39s
✔️ integration-amazon.aws-6 SUCCESS in 7m 09s
✔️ integration-amazon.aws-7 SUCCESS in 6m 42s
✔️ integration-amazon.aws-8 SUCCESS in 12m 12s
✔️ integration-amazon.aws-9 SUCCESS in 11m 31s
✔️ integration-amazon.aws-10 SUCCESS in 11m 11s
✔️ integration-amazon.aws-11 SUCCESS in 20m 56s
✔️ integration-amazon.aws-12 SUCCESS in 17m 33s
✔️ integration-amazon.aws-13 SUCCESS in 8m 21s
✔️ integration-amazon.aws-14 SUCCESS in 9m 23s
✔️ integration-amazon.aws-15 SUCCESS in 8m 06s
✔️ integration-amazon.aws-16 SUCCESS in 14m 50s
✔️ integration-amazon.aws-17 SUCCESS in 9m 42s
✔️ integration-amazon.aws-18 SUCCESS in 11m 50s
✔️ integration-amazon.aws-19 SUCCESS in 11m 55s
Skipped 25 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jun 4, 2024
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/89bd0bbe160246398b119dfbd60cb1b5

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 16m 16s
✔️ ansible-test-splitter SUCCESS in 6m 40s
✔️ integration-amazon.aws-1 SUCCESS in 29m 12s
✔️ integration-amazon.aws-2 SUCCESS in 19m 57s
✔️ integration-amazon.aws-3 SUCCESS in 15m 32s
✔️ integration-amazon.aws-4 SUCCESS in 11m 26s
✔️ integration-amazon.aws-5 SUCCESS in 11m 19s
integration-amazon.aws-6 RETRY_LIMIT in 1m 43s
integration-amazon.aws-7 FAILURE in 8m 52s
✔️ integration-amazon.aws-8 SUCCESS in 16m 41s
✔️ integration-amazon.aws-9 SUCCESS in 14m 31s
✔️ integration-amazon.aws-10 SUCCESS in 15m 27s
✔️ integration-amazon.aws-11 SUCCESS in 20m 57s
✔️ integration-amazon.aws-12 SUCCESS in 17m 35s
✔️ integration-amazon.aws-13 SUCCESS in 16m 23s
✔️ integration-amazon.aws-14 SUCCESS in 15m 44s
✔️ integration-amazon.aws-15 SUCCESS in 8m 36s
✔️ integration-amazon.aws-16 SUCCESS in 12m 20s
integration-amazon.aws-17 RETRY_LIMIT in 1m 45s
✔️ integration-amazon.aws-18 SUCCESS in 9m 31s
✔️ integration-amazon.aws-19 SUCCESS in 9m 42s
Skipped 25 jobs

@alinabuzachis
Copy link
Collaborator

regate

Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/d62608c73f56401a9fc69a0ad0599af3

✔️ ansible-galaxy-importer SUCCESS in 5m 53s
✔️ build-ansible-collection SUCCESS in 15m 06s
✔️ ansible-test-splitter SUCCESS in 8m 07s
✔️ integration-amazon.aws-1 SUCCESS in 27m 00s
✔️ integration-amazon.aws-2 SUCCESS in 8m 07s
✔️ integration-amazon.aws-3 SUCCESS in 8m 58s
✔️ integration-amazon.aws-4 SUCCESS in 10m 51s
✔️ integration-amazon.aws-5 SUCCESS in 7m 30s
✔️ integration-amazon.aws-6 SUCCESS in 8m 08s
integration-amazon.aws-7 FAILURE in 7m 36s
✔️ integration-amazon.aws-8 SUCCESS in 12m 23s
✔️ integration-amazon.aws-9 SUCCESS in 7m 17s
✔️ integration-amazon.aws-10 SUCCESS in 9m 10s
✔️ integration-amazon.aws-11 SUCCESS in 12m 41s
✔️ integration-amazon.aws-12 SUCCESS in 13m 29s
✔️ integration-amazon.aws-13 SUCCESS in 17m 44s
✔️ integration-amazon.aws-14 SUCCESS in 12m 37s
✔️ integration-amazon.aws-15 SUCCESS in 7m 45s
✔️ integration-amazon.aws-16 SUCCESS in 12m 42s
✔️ integration-amazon.aws-17 SUCCESS in 12m 21s
✔️ integration-amazon.aws-18 SUCCESS in 7m 15s
✔️ integration-amazon.aws-19 SUCCESS in 12m 59s
Skipped 25 jobs

@gravesm gravesm merged commit 6ebf143 into stable-8 Jun 4, 2024
36 of 37 checks passed
@gravesm gravesm deleted the patchback/backports/stable-8/0d1a604b9aaa1c4e35274eaf3ebfe97fdd5fd00c/pr-1979 branch June 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants