Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1979/0d1a604b backport][stable-7] Don't ignore IPv6 addresses when a single network interface is specified #2112

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 24, 2024

This is a backport of PR #1979 as merged into main (0d1a604).

SUMMARY

When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

…ied (#1979)

Don't ignore IPv6 addresses when a single network interface is specified

SUMMARY

When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
(cherry picked from commit 0d1a604)
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8ebeece15ee74a398ed12d6aac168daf

✔️ ansible-galaxy-importer SUCCESS in 5m 11s
✔️ build-ansible-collection SUCCESS in 16m 58s
✔️ ansible-test-splitter SUCCESS in 6m 46s
✔️ integration-amazon.aws-1 SUCCESS in 23m 52s
✔️ integration-amazon.aws-2 SUCCESS in 14m 03s
✔️ integration-amazon.aws-3 SUCCESS in 9m 39s
✔️ integration-amazon.aws-4 SUCCESS in 8m 37s
✔️ integration-amazon.aws-5 SUCCESS in 8m 39s
✔️ integration-amazon.aws-6 SUCCESS in 7m 33s
✔️ integration-amazon.aws-7 SUCCESS in 7m 27s
✔️ integration-amazon.aws-8 SUCCESS in 13m 49s
✔️ integration-amazon.aws-9 SUCCESS in 7m 58s
✔️ integration-amazon.aws-10 SUCCESS in 8m 35s
✔️ integration-amazon.aws-11 SUCCESS in 7m 34s
✔️ integration-amazon.aws-12 SUCCESS in 10m 37s
✔️ integration-amazon.aws-13 SUCCESS in 11m 05s
✔️ integration-amazon.aws-14 SUCCESS in 11m 18s
✔️ integration-amazon.aws-15 SUCCESS in 7m 17s
✔️ integration-amazon.aws-16 SUCCESS in 7m 40s
✔️ integration-amazon.aws-17 SUCCESS in 6m 54s
✔️ integration-amazon.aws-18 SUCCESS in 7m 49s
✔️ integration-amazon.aws-19 SUCCESS in 8m 05s
Skipped 25 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jun 4, 2024
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/4e4b25f2bd9249d9a63e9b84513169c1

✔️ ansible-galaxy-importer SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 16m 00s
✔️ ansible-test-splitter SUCCESS in 8m 25s
✔️ integration-amazon.aws-1 SUCCESS in 31m 00s
✔️ integration-amazon.aws-2 SUCCESS in 17m 19s
✔️ integration-amazon.aws-3 SUCCESS in 14m 27s
✔️ integration-amazon.aws-4 SUCCESS in 11m 10s
✔️ integration-amazon.aws-5 SUCCESS in 8m 22s
✔️ integration-amazon.aws-6 SUCCESS in 7m 09s
integration-amazon.aws-7 FAILURE in 7m 26s
✔️ integration-amazon.aws-8 SUCCESS in 11m 52s
✔️ integration-amazon.aws-9 SUCCESS in 11m 25s
✔️ integration-amazon.aws-10 SUCCESS in 11m 16s
✔️ integration-amazon.aws-11 SUCCESS in 12m 19s
✔️ integration-amazon.aws-12 SUCCESS in 13m 37s
✔️ integration-amazon.aws-13 SUCCESS in 10m 34s
✔️ integration-amazon.aws-14 SUCCESS in 12m 09s
✔️ integration-amazon.aws-15 SUCCESS in 7m 30s
✔️ integration-amazon.aws-16 SUCCESS in 13m 27s
✔️ integration-amazon.aws-17 SUCCESS in 11m 03s
✔️ integration-amazon.aws-18 SUCCESS in 11m 46s
✔️ integration-amazon.aws-19 SUCCESS in 7m 48s
Skipped 25 jobs

@gravesm gravesm merged commit a9edc5a into stable-7 Jun 4, 2024
36 of 37 checks passed
@gravesm gravesm deleted the patchback/backports/stable-7/0d1a604b9aaa1c4e35274eaf3ebfe97fdd5fd00c/pr-1979 branch June 4, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants