Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudwatch_metric_alarm: include evaluate_low_sample_count_percentile #2111

Merged
merged 3 commits into from
May 28, 2024
Merged

cloudwatch_metric_alarm: include evaluate_low_sample_count_percentile #2111

merged 3 commits into from
May 28, 2024

Conversation

GomathiselviS
Copy link
Collaborator

@GomathiselviS GomathiselviS commented May 23, 2024 •
edited
Loading

SUMMARY

Fixes #1940

This PR adds evaluate_low_sample_count_percentile parameter

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/047ba9f649004063aa3c71c4dde45c81

✔️ ansible-galaxy-importer SUCCESS in 5m 30s
✔️ build-ansible-collection SUCCESS in 16m 30s
✔️ ansible-test-splitter SUCCESS in 5m 36s
✔️ integration-amazon.aws-1 SUCCESS in 8m 35s
✔️ integration-community.aws-1 SUCCESS in 57m 59s
Skipped 42 jobs

mandar242
mandar242 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@mandar242 mandar242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpicks. otherwise LGTM!

@GomathiselviS GomathiselviS added the mergeit Merge the PR (SoftwareFactory) label May 28, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/f2afe1612bf2430c8d00f484f65ac7b5

✔️ ansible-galaxy-importer SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 16m 34s
✔️ ansible-test-splitter SUCCESS in 7m 37s
✔️ integration-amazon.aws-1 SUCCESS in 7m 25s
✔️ integration-community.aws-1 SUCCESS in 46m 00s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2389122 into ansible-collections:main May 28, 2024
35 of 36 checks passed
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Jun 26, 2024
@GomathiselviS @alinabuzachis
cloudwatch_metric_alarm: include evaluate_low_sample_count_percentile (…
e031600 
…ansible-collections#2111)

cloudwatch_metric_alarm: include evaluate_low_sample_count_percentile

SUMMARY


Fixes ansible-collections#1940
This PR adds evaluate_low_sample_count_percentile  parameter
ISSUE TYPE



Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin
@tremble tremble added the backport-8 PR should be backported to the stable-8 branch label Aug 28, 2024
@patchback Patchback
Copy link

patchback bot commented Aug 28, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/2389122d5d2b289a34e2509495bf332fcc585ee8/pr-2111

Backported as #2255

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 28, 2024
@GomathiselviS @patchback
cloudwatch_metric_alarm: include evaluate_low_sample_count_percentile (…
a725335 
…#2111)

cloudwatch_metric_alarm: include evaluate_low_sample_count_percentile

SUMMARY

Fixes #1940
This PR adds evaluate_low_sample_count_percentile  parameter
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Bikouo Aubin
(cherry picked from commit 2389122)
@patchback patchback bot mentioned this pull request Aug 28, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 28, 2024
@patchback
[PR #2111/2389122d backport][stable-8] cloudwatch_metric_alarm: inclu…
c90938a 
…de evaluate_low_sample_count_percentile (#2255)

This is a backport of PR #2111 as merged into main (2389122).
SUMMARY


Fixes #1940
This PR adds evaluate_low_sample_count_percentile  parameter
ISSUE TYPE



Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@mandar242 mandar242 mandar242 approved these changes

Assignees
No one assigned
Labels
backport-8 PR should be backported to the stable-8 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amazon.aws.cloudwatch_metric_alarm to include "evaluate_low_sample_count_percentile"
4 participants
@GomathiselviS @mandar242 @abikouo @tremble