Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3_object - fix MemoryError when downloading large files #2108

Merged
merged 1 commit into from
May 22, 2024
Merged

s3_object - fix MemoryError when downloading large files #2108

merged 1 commit into from
May 22, 2024

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 22, 2024

SUMMARY

fixes: #2107

The refactor in #1139 is triggering a full download of the file into memory when downloading files, this downloaded content was then being thrown away.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_object

ADDITIONAL INFORMATION

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7e8cfb9ed70b45c2ba6fe9107a851c8a

✔️ ansible-galaxy-importer SUCCESS in 5m 12s
✔️ build-ansible-collection SUCCESS in 15m 16s
✔️ ansible-test-splitter SUCCESS in 7m 40s
✔️ integration-amazon.aws-1 SUCCESS in 12m 21s
Skipped 43 jobs

@tremble tremble marked this pull request as ready for review May 22, 2024 09:22
@tremble tremble requested review from alinabuzachis and abikouo May 22, 2024 09:23
@tremble tremble added the backport-8 PR should be backported to the stable-8 branch label May 22, 2024
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 22, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8d887a44d6a147ffa5f77b3de50a95e4

✔️ ansible-galaxy-importer SUCCESS in 5m 34s
✔️ build-ansible-collection SUCCESS in 17m 39s
✔️ ansible-test-splitter SUCCESS in 7m 06s
✔️ integration-amazon.aws-1 SUCCESS in 13m 10s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4829217 into ansible-collections:main May 22, 2024
38 checks passed
@patchback Patchback
Copy link

patchback bot commented May 22, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/482921780bb6a7c08b74931a496d4ab8e5dbc71f/pr-2108

Backported as #2109

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 22, 2024
@tremble @patchback
s3_object - fix MemoryError when downloading large files (#2108)
70e2aea 
s3_object - fix MemoryError when downloading large files

SUMMARY
fixes: #2107
The refactor in #1139 is triggering a full download of the file into memory when downloading files, this downloaded content was then being thrown away.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
(cherry picked from commit 4829217)
@patchback patchback bot mentioned this pull request May 22, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 29, 2024
@patchback
s3_object - fix MemoryError when downloading large files (#2108) (#2109)
cc45aaa 
[PR #2108/48292178 backport][stable-8] s3_object - fix MemoryError when downloading large files

This is a backport of PR #2108 as merged into main (4829217).
SUMMARY
fixes: #2107
The refactor in #1139 is triggering a full download of the file into memory when downloading files, this downloaded content was then being thrown away.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@tremble tremble deleted the issues/2107 branch June 12, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-8 PR should be backported to the stable-8 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MemoryError when downloading a large file from S3 with community.aws 8.0.0
3 participants
@tremble @alinabuzachis @abikouo