Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part #2]: Ensures the modules documentation follows the correct formats #2081

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link

github-actions bot commented May 10, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a984ae72e43b4571984e741b7abc52f2

✔️ ansible-galaxy-importer SUCCESS in 5m 34s
✔️ build-ansible-collection SUCCESS in 17m 21s
✔️ ansible-test-splitter SUCCESS in 6m 33s
✔️ integration-amazon.aws-1 SUCCESS in 14m 28s
✔️ integration-amazon.aws-2 SUCCESS in 25m 59s
✔️ integration-amazon.aws-3 SUCCESS in 16m 52s
✔️ integration-amazon.aws-4 SUCCESS in 17m 13s
✔️ integration-amazon.aws-5 SUCCESS in 13m 35s
✔️ integration-amazon.aws-6 SUCCESS in 11m 54s
✔️ integration-amazon.aws-7 SUCCESS in 8m 03s
✔️ integration-amazon.aws-8 SUCCESS in 6m 33s
✔️ integration-amazon.aws-9 SUCCESS in 7m 53s
✔️ integration-amazon.aws-10 SUCCESS in 22m 51s
✔️ integration-amazon.aws-11 SUCCESS in 9m 08s
✔️ integration-amazon.aws-12 SUCCESS in 17m 06s
✔️ integration-amazon.aws-13 SUCCESS in 8m 48s
✔️ integration-amazon.aws-14 SUCCESS in 13m 08s
✔️ integration-amazon.aws-15 SUCCESS in 13m 07s
✔️ integration-amazon.aws-16 SUCCESS in 12m 26s
✔️ integration-amazon.aws-17 SUCCESS in 12m 25s
✔️ integration-amazon.aws-18 SUCCESS in 13m 32s
✔️ integration-amazon.aws-19 SUCCESS in 8m 24s
✔️ integration-amazon.aws-20 SUCCESS in 12m 24s
✔️ integration-amazon.aws-21 SUCCESS in 7m 48s
Skipped 23 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e643455d234a430e9b392e0d76009a2b

✔️ ansible-galaxy-importer SUCCESS in 5m 59s
✔️ build-ansible-collection SUCCESS in 16m 08s
✔️ ansible-test-splitter SUCCESS in 5m 42s
✔️ integration-amazon.aws-1 SUCCESS in 16m 12s
✔️ integration-amazon.aws-2 SUCCESS in 31m 25s
✔️ integration-amazon.aws-3 SUCCESS in 18m 47s
✔️ integration-amazon.aws-4 SUCCESS in 14m 07s
✔️ integration-amazon.aws-5 SUCCESS in 12m 47s
✔️ integration-amazon.aws-6 SUCCESS in 11m 11s
✔️ integration-amazon.aws-7 SUCCESS in 8m 24s
✔️ integration-amazon.aws-8 SUCCESS in 7m 08s
✔️ integration-amazon.aws-9 SUCCESS in 8m 13s
✔️ integration-amazon.aws-10 SUCCESS in 22m 20s
✔️ integration-amazon.aws-11 SUCCESS in 12m 00s
✔️ integration-amazon.aws-12 SUCCESS in 16m 07s
✔️ integration-amazon.aws-13 SUCCESS in 9m 44s
✔️ integration-amazon.aws-14 SUCCESS in 15m 56s
✔️ integration-amazon.aws-15 SUCCESS in 11m 10s
✔️ integration-amazon.aws-16 SUCCESS in 11m 20s
✔️ integration-amazon.aws-17 SUCCESS in 7m 31s
✔️ integration-amazon.aws-18 SUCCESS in 8m 49s
✔️ integration-amazon.aws-19 SUCCESS in 7m 24s
✔️ integration-amazon.aws-20 SUCCESS in 7m 31s
✔️ integration-amazon.aws-21 SUCCESS in 9m 00s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/26667be4dfeb4e808d143cfa91627153

✔️ ansible-galaxy-importer SUCCESS in 5m 16s
✔️ build-ansible-collection SUCCESS in 19m 39s
✔️ ansible-test-splitter SUCCESS in 10m 09s
✔️ integration-amazon.aws-1 SUCCESS in 16m 09s
✔️ integration-amazon.aws-2 SUCCESS in 30m 31s
✔️ integration-amazon.aws-3 SUCCESS in 15m 50s
✔️ integration-amazon.aws-4 SUCCESS in 8m 13s
✔️ integration-amazon.aws-5 SUCCESS in 9m 47s
✔️ integration-amazon.aws-6 SUCCESS in 8m 17s
✔️ integration-amazon.aws-7 SUCCESS in 7m 40s
✔️ integration-amazon.aws-8 SUCCESS in 10m 00s
✔️ integration-amazon.aws-9 SUCCESS in 10m 37s
✔️ integration-amazon.aws-10 SUCCESS in 27m 54s
✔️ integration-amazon.aws-11 SUCCESS in 12m 20s
✔️ integration-amazon.aws-12 SUCCESS in 16m 26s
✔️ integration-amazon.aws-13 SUCCESS in 7m 52s
✔️ integration-amazon.aws-14 SUCCESS in 16m 38s
✔️ integration-amazon.aws-15 SUCCESS in 11m 18s
✔️ integration-amazon.aws-16 SUCCESS in 15m 16s
✔️ integration-amazon.aws-17 SUCCESS in 8m 10s
✔️ integration-amazon.aws-18 SUCCESS in 9m 24s
✔️ integration-amazon.aws-19 SUCCESS in 8m 42s
✔️ integration-amazon.aws-20 SUCCESS in 7m 19s
integration-amazon.aws-21 RETRY_LIMIT in 6m 57s
Skipped 23 jobs

Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/amazon.aws for 2081,6eae9e07b309cf901f01dbc32c4141c268330618

@alinabuzachis alinabuzachis requested a review from abikouo May 22, 2024 09:58
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2bec5f48a0f3427b8017ebe0f757477d

✔️ ansible-galaxy-importer SUCCESS in 7m 12s
✔️ build-ansible-collection SUCCESS in 15m 53s
✔️ ansible-test-splitter SUCCESS in 7m 25s
✔️ integration-amazon.aws-1 SUCCESS in 14m 25s
✔️ integration-amazon.aws-2 SUCCESS in 27m 49s
✔️ integration-amazon.aws-3 SUCCESS in 18m 14s
✔️ integration-amazon.aws-4 SUCCESS in 14m 17s
✔️ integration-amazon.aws-5 SUCCESS in 10m 37s
✔️ integration-amazon.aws-6 SUCCESS in 9m 54s
✔️ integration-amazon.aws-7 SUCCESS in 9m 40s
✔️ integration-amazon.aws-8 SUCCESS in 6m 07s
✔️ integration-amazon.aws-9 SUCCESS in 9m 31s
✔️ integration-amazon.aws-10 SUCCESS in 25m 22s
✔️ integration-amazon.aws-11 SUCCESS in 9m 04s
✔️ integration-amazon.aws-12 SUCCESS in 14m 31s
✔️ integration-amazon.aws-13 SUCCESS in 11m 12s
✔️ integration-amazon.aws-14 SUCCESS in 12m 43s
✔️ integration-amazon.aws-15 SUCCESS in 11m 49s
✔️ integration-amazon.aws-16 SUCCESS in 12m 38s
✔️ integration-amazon.aws-17 SUCCESS in 10m 42s
✔️ integration-amazon.aws-18 SUCCESS in 11m 37s
✔️ integration-amazon.aws-19 SUCCESS in 9m 28s
✔️ integration-amazon.aws-20 SUCCESS in 8m 58s
✔️ integration-amazon.aws-21 SUCCESS in 9m 29s
Skipped 23 jobs

plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance_info.py Outdated Show resolved Hide resolved
@tremble tremble added skip-changelog mergeit Merge the PR (SoftwareFactory) labels May 23, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d7880e7a6fd24d8f9879594ba1464686

✔️ ansible-galaxy-importer SUCCESS in 5m 35s
✔️ build-ansible-collection SUCCESS in 15m 20s
✔️ ansible-test-splitter SUCCESS in 5m 36s
✔️ integration-amazon.aws-1 SUCCESS in 13m 54s
✔️ integration-amazon.aws-2 SUCCESS in 25m 48s
✔️ integration-amazon.aws-3 SUCCESS in 16m 32s
✔️ integration-amazon.aws-4 SUCCESS in 16m 19s
✔️ integration-amazon.aws-5 SUCCESS in 13m 18s
✔️ integration-amazon.aws-6 SUCCESS in 12m 48s
✔️ integration-amazon.aws-7 SUCCESS in 9m 47s
✔️ integration-amazon.aws-8 SUCCESS in 7m 10s
✔️ integration-amazon.aws-9 SUCCESS in 8m 11s
✔️ integration-amazon.aws-10 SUCCESS in 23m 33s
✔️ integration-amazon.aws-11 SUCCESS in 16m 57s
✔️ integration-amazon.aws-12 SUCCESS in 14m 06s
✔️ integration-amazon.aws-13 SUCCESS in 13m 03s
✔️ integration-amazon.aws-14 SUCCESS in 13m 57s
✔️ integration-amazon.aws-15 SUCCESS in 12m 21s
✔️ integration-amazon.aws-16 SUCCESS in 13m 01s
✔️ integration-amazon.aws-17 SUCCESS in 8m 48s
✔️ integration-amazon.aws-18 SUCCESS in 19m 47s
✔️ integration-amazon.aws-19 SUCCESS in 8m 56s
✔️ integration-amazon.aws-20 SUCCESS in 8m 59s
✔️ integration-amazon.aws-21 SUCCESS in 9m 52s
Skipped 23 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8a6232e into ansible-collections:main May 23, 2024
37 of 38 checks passed
@tremble tremble added the backport-8 PR should be backported to the stable-8 branch label Aug 27, 2024
Copy link

patchback bot commented Aug 27, 2024

Backport to stable-8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 8a6232e on top of patchback/backports/stable-8/8a6232e6baab5d27b65f6f56093088f40efeae5d/pr-2081

Backporting merged PR #2081 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-8/8a6232e6baab5d27b65f6f56093088f40efeae5d/pr-2081 upstream/stable-8
  4. Now, cherry-pick PR [Part #2]: Ensures the modules documentation follows the correct formats #2081 contents into that branch:
    $ git cherry-pick -x 8a6232e6baab5d27b65f6f56093088f40efeae5d
    If it'll yell at you with something like fatal: Commit 8a6232e6baab5d27b65f6f56093088f40efeae5d is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 8a6232e6baab5d27b65f6f56093088f40efeae5d
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR [Part #2]: Ensures the modules documentation follows the correct formats #2081 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-8/8a6232e6baab5d27b65f6f56093088f40efeae5d/pr-2081
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@tremble tremble added the backport_failed Backport failed, needs review label Aug 27, 2024
Copy link

patchback bot commented Aug 27, 2024

Backport to stable-failed: 💔 cherry-picking failed — target branch does not exist

❌ Failed to find branch stable-failed

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@tremble tremble added backport-8 PR should be backported to the stable-8 branch and removed backport_failed Backport failed, needs review backport-8 PR should be backported to the stable-8 branch labels Aug 27, 2024
Copy link

patchback bot commented Aug 27, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/8a6232e6baab5d27b65f6f56093088f40efeae5d/pr-2081

Backported as #2246

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 27, 2024
…ats (#2081)

[Part #2]: Ensures the modules documentation follows the correct formats

SUMMARY

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
Reviewed-by: Mark Chappell
(cherry picked from commit 8a6232e)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 28, 2024
…ats (#2081) (#2246)

This is a backport of PR #2081 as merged into main (8a6232e).
SUMMARY


ISSUE TYPE


Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
GomathiselviS pushed a commit to GomathiselviS/amazon.aws that referenced this pull request Oct 16, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit to GomathiselviS/amazon.aws that referenced this pull request Oct 16, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit to GomathiselviS/amazon.aws that referenced this pull request Oct 17, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit to GomathiselviS/amazon.aws that referenced this pull request Oct 17, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit that referenced this pull request Oct 17, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit to GomathiselviS/amazon.aws that referenced this pull request Oct 17, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit that referenced this pull request Oct 17, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit that referenced this pull request Oct 17, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit that referenced this pull request Oct 17, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit that referenced this pull request Oct 17, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
GomathiselviS pushed a commit to GomathiselviS/amazon.aws that referenced this pull request Oct 24, 2024
SUMMARY
Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.
ISSUE TYPE

Feature Pull Request

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Haris Okanovic <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c235bd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 PR should be backported to the stable-8 branch mergeit Merge the PR (SoftwareFactory) skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants