Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize refactor #2006

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Feb 29, 2024

SUMMARY

fixes: #2001

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/iam.py
plugins/module_utils/transformation.py

ADDITIONAL INFORMATION

Note: also tinkers a little with Type Hinting, not sure of the value

TODO:

  • Initial transform code
  • Unit tests for transform code
  • initial iam updates
  • Basic unit tests for iam updates
  • changelog

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ee450c053801404994ae91ec7abd8c91

✔️ ansible-galaxy-importer SUCCESS in 5m 20s
✔️ build-ansible-collection SUCCESS in 15m 51s
✔️ ansible-test-splitter SUCCESS in 5m 21s
✔️ integration-amazon.aws-1 SUCCESS in 13m 48s
✔️ integration-amazon.aws-2 SUCCESS in 28m 29s
✔️ integration-amazon.aws-3 SUCCESS in 16m 29s
✔️ integration-amazon.aws-4 SUCCESS in 27m 18s
✔️ integration-amazon.aws-5 SUCCESS in 28m 14s
✔️ integration-amazon.aws-6 SUCCESS in 35m 10s
✔️ integration-amazon.aws-7 SUCCESS in 33m 51s
✔️ integration-amazon.aws-8 SUCCESS in 37m 48s
✔️ integration-amazon.aws-9 SUCCESS in 13m 41s
✔️ integration-amazon.aws-10 SUCCESS in 15m 26s
✔️ integration-amazon.aws-11 SUCCESS in 20m 03s
✔️ integration-amazon.aws-12 SUCCESS in 21m 26s
✔️ integration-amazon.aws-13 SUCCESS in 10m 51s
✔️ integration-amazon.aws-14 SUCCESS in 19m 58s
✔️ integration-amazon.aws-15 SUCCESS in 25m 24s
✔️ integration-amazon.aws-16 SUCCESS in 28m 43s
✔️ integration-amazon.aws-17 SUCCESS in 18m 57s
✔️ integration-amazon.aws-18 SUCCESS in 13m 37s
✔️ integration-amazon.aws-19 SUCCESS in 34m 03s
✔️ integration-amazon.aws-20 SUCCESS in 16m 51s
✔️ integration-amazon.aws-21 SUCCESS in 23m 04s
✔️ integration-amazon.aws-22 SUCCESS in 19m 43s
✔️ integration-community.aws-1 SUCCESS in 22m 46s
✔️ integration-community.aws-2 SUCCESS in 16m 58s
✔️ integration-community.aws-3 SUCCESS in 12m 32s
✔️ integration-community.aws-4 SUCCESS in 6m 54s
✔️ integration-community.aws-5 SUCCESS in 9m 17s
✔️ integration-community.aws-6 SUCCESS in 10m 11s
✔️ integration-community.aws-7 SUCCESS in 10m 42s
✔️ integration-community.aws-8 SUCCESS in 9m 18s
✔️ integration-community.aws-9 SUCCESS in 8m 02s
✔️ integration-community.aws-10 SUCCESS in 12m 02s
✔️ integration-community.aws-11 SUCCESS in 20m 33s
✔️ integration-community.aws-12 SUCCESS in 9m 07s
Skipped 10 jobs

@tremble tremble force-pushed the normalize_refactor branch from ee7ea6a to ef78258 Compare March 22, 2024 16:38
@tremble tremble force-pushed the normalize_refactor branch from ef78258 to 7d9bcf8 Compare March 22, 2024 16:41
@tremble tremble marked this pull request as ready for review March 22, 2024 16:47
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/86b65cecfcc74eb5b8ae5fa6a753f66d

✔️ ansible-galaxy-importer SUCCESS in 5m 10s
✔️ build-ansible-collection SUCCESS in 14m 28s
✔️ ansible-test-splitter SUCCESS in 6m 12s
✔️ integration-amazon.aws-1 SUCCESS in 13m 51s
✔️ integration-amazon.aws-2 SUCCESS in 38m 59s
✔️ integration-amazon.aws-3 SUCCESS in 17m 40s
✔️ integration-amazon.aws-4 SUCCESS in 24m 10s
✔️ integration-amazon.aws-5 SUCCESS in 24m 53s
✔️ integration-amazon.aws-6 SUCCESS in 33m 25s
✔️ integration-amazon.aws-7 SUCCESS in 32m 30s
✔️ integration-amazon.aws-8 SUCCESS in 31m 39s
✔️ integration-amazon.aws-9 SUCCESS in 13m 24s
✔️ integration-amazon.aws-10 SUCCESS in 11m 04s
✔️ integration-amazon.aws-11 SUCCESS in 17m 55s
✔️ integration-amazon.aws-12 SUCCESS in 19m 46s
✔️ integration-amazon.aws-13 SUCCESS in 12m 32s
✔️ integration-amazon.aws-14 SUCCESS in 20m 03s
✔️ integration-amazon.aws-15 SUCCESS in 23m 37s
✔️ integration-amazon.aws-16 SUCCESS in 25m 08s
✔️ integration-amazon.aws-17 SUCCESS in 11m 44s
✔️ integration-amazon.aws-18 SUCCESS in 10m 53s
✔️ integration-amazon.aws-19 SUCCESS in 29m 40s
✔️ integration-amazon.aws-20 SUCCESS in 17m 31s
✔️ integration-amazon.aws-21 SUCCESS in 26m 52s
✔️ integration-amazon.aws-22 SUCCESS in 18m 50s
✔️ integration-community.aws-1 SUCCESS in 28m 09s
✔️ integration-community.aws-2 SUCCESS in 17m 15s
integration-community.aws-3 RETRY_LIMIT in 6m 56s
✔️ integration-community.aws-4 SUCCESS in 7m 54s
✔️ integration-community.aws-5 SUCCESS in 5m 39s
✔️ integration-community.aws-6 SUCCESS in 7m 24s
✔️ integration-community.aws-7 SUCCESS in 7m 22s
✔️ integration-community.aws-8 SUCCESS in 13m 32s
✔️ integration-community.aws-9 SUCCESS in 9m 38s
✔️ integration-community.aws-10 SUCCESS in 14m 55s
✔️ integration-community.aws-11 SUCCESS in 22m 14s
✔️ integration-community.aws-12 SUCCESS in 7m 32s
Skipped 10 jobs

@alinabuzachis
Copy link
Collaborator

recheck

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/13c5a869880c4613b3be1e28748d3f61

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 16m 59s
✔️ ansible-test-splitter SUCCESS in 5m 52s
✔️ integration-amazon.aws-1 SUCCESS in 13m 49s
✔️ integration-amazon.aws-2 SUCCESS in 35m 55s
✔️ integration-amazon.aws-3 SUCCESS in 16m 24s
✔️ integration-amazon.aws-4 SUCCESS in 26m 46s
✔️ integration-amazon.aws-5 SUCCESS in 28m 10s
✔️ integration-amazon.aws-6 SUCCESS in 35m 32s
✔️ integration-amazon.aws-7 SUCCESS in 31m 37s
✔️ integration-amazon.aws-8 SUCCESS in 32m 09s
✔️ integration-amazon.aws-9 SUCCESS in 13m 12s
✔️ integration-amazon.aws-10 SUCCESS in 15m 13s
✔️ integration-amazon.aws-11 SUCCESS in 21m 51s
✔️ integration-amazon.aws-12 SUCCESS in 20m 20s
✔️ integration-amazon.aws-13 SUCCESS in 10m 45s
✔️ integration-amazon.aws-14 SUCCESS in 19m 10s
✔️ integration-amazon.aws-15 SUCCESS in 24m 49s
✔️ integration-amazon.aws-16 SUCCESS in 28m 24s
✔️ integration-amazon.aws-17 SUCCESS in 19m 48s
✔️ integration-amazon.aws-18 SUCCESS in 15m 19s
✔️ integration-amazon.aws-19 SUCCESS in 29m 45s
✔️ integration-amazon.aws-20 SUCCESS in 17m 24s
✔️ integration-amazon.aws-21 SUCCESS in 24m 07s
✔️ integration-amazon.aws-22 SUCCESS in 20m 19s
✔️ integration-community.aws-1 SUCCESS in 27m 19s
✔️ integration-community.aws-2 SUCCESS in 16m 57s
✔️ integration-community.aws-3 SUCCESS in 15m 42s
✔️ integration-community.aws-4 SUCCESS in 8m 21s
✔️ integration-community.aws-5 SUCCESS in 7m 07s
✔️ integration-community.aws-6 SUCCESS in 7m 20s
✔️ integration-community.aws-7 SUCCESS in 7m 08s
✔️ integration-community.aws-8 SUCCESS in 9m 46s
✔️ integration-community.aws-9 SUCCESS in 8m 20s
✔️ integration-community.aws-10 SUCCESS in 9m 20s
✔️ integration-community.aws-11 SUCCESS in 20m 40s
✔️ integration-community.aws-12 SUCCESS in 6m 44s
Skipped 10 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 25, 2024
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/2e23fbcbd83e4586ad55e661c4493ae8

✔️ ansible-galaxy-importer SUCCESS in 5m 49s
✔️ build-ansible-collection SUCCESS in 16m 00s
✔️ ansible-test-splitter SUCCESS in 6m 03s
✔️ integration-amazon.aws-1 SUCCESS in 13m 49s
✔️ integration-amazon.aws-2 SUCCESS in 32m 11s
✔️ integration-amazon.aws-3 SUCCESS in 16m 10s
✔️ integration-amazon.aws-4 SUCCESS in 26m 47s
✔️ integration-amazon.aws-5 SUCCESS in 27m 51s
✔️ integration-amazon.aws-6 SUCCESS in 34m 31s
✔️ integration-amazon.aws-7 SUCCESS in 34m 56s
✔️ integration-amazon.aws-8 SUCCESS in 33m 45s
✔️ integration-amazon.aws-9 SUCCESS in 12m 29s
✔️ integration-amazon.aws-10 SUCCESS in 15m 16s
✔️ integration-amazon.aws-11 SUCCESS in 18m 04s
✔️ integration-amazon.aws-12 SUCCESS in 22m 30s
✔️ integration-amazon.aws-13 SUCCESS in 17m 55s
✔️ integration-amazon.aws-14 SUCCESS in 20m 22s
✔️ integration-amazon.aws-15 SUCCESS in 24m 54s
✔️ integration-amazon.aws-16 SUCCESS in 21m 48s
✔️ integration-amazon.aws-17 SUCCESS in 12m 00s
integration-amazon.aws-18 FAILURE in 10m 56s
✔️ integration-amazon.aws-19 SUCCESS in 30m 45s
✔️ integration-amazon.aws-20 SUCCESS in 17m 01s
✔️ integration-amazon.aws-21 SUCCESS in 22m 51s
✔️ integration-amazon.aws-22 SUCCESS in 19m 46s
✔️ integration-community.aws-1 SUCCESS in 27m 32s
✔️ integration-community.aws-2 SUCCESS in 18m 17s
✔️ integration-community.aws-3 SUCCESS in 20m 36s
✔️ integration-community.aws-4 SUCCESS in 5m 33s
✔️ integration-community.aws-5 SUCCESS in 5m 27s
✔️ integration-community.aws-6 SUCCESS in 8m 33s
✔️ integration-community.aws-7 SUCCESS in 9m 13s
✔️ integration-community.aws-8 SUCCESS in 10m 46s
✔️ integration-community.aws-9 SUCCESS in 6m 43s
✔️ integration-community.aws-10 SUCCESS in 9m 19s
✔️ integration-community.aws-11 SUCCESS in 16m 49s
✔️ integration-community.aws-12 SUCCESS in 6m 49s
Skipped 10 jobs

@tremble
Copy link
Contributor Author

tremble commented Mar 25, 2024

regate

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/cc73282856b1425b81b214d62b12913d

✔️ ansible-galaxy-importer SUCCESS in 5m 29s
✔️ build-ansible-collection SUCCESS in 15m 19s
✔️ ansible-test-splitter SUCCESS in 6m 24s
✔️ integration-amazon.aws-1 SUCCESS in 13m 53s
✔️ integration-amazon.aws-2 SUCCESS in 36m 07s
✔️ integration-amazon.aws-3 SUCCESS in 16m 20s
✔️ integration-amazon.aws-4 SUCCESS in 26m 41s
✔️ integration-amazon.aws-5 SUCCESS in 27m 15s
✔️ integration-amazon.aws-6 SUCCESS in 38m 04s
✔️ integration-amazon.aws-7 SUCCESS in 34m 20s
✔️ integration-amazon.aws-8 SUCCESS in 33m 08s
✔️ integration-amazon.aws-9 SUCCESS in 13m 56s
✔️ integration-amazon.aws-10 SUCCESS in 15m 06s
✔️ integration-amazon.aws-11 SUCCESS in 17m 49s
✔️ integration-amazon.aws-12 SUCCESS in 22m 00s
✔️ integration-amazon.aws-13 SUCCESS in 10m 10s
✔️ integration-amazon.aws-14 SUCCESS in 20m 07s
✔️ integration-amazon.aws-15 SUCCESS in 24m 27s
✔️ integration-amazon.aws-16 SUCCESS in 21m 12s
✔️ integration-amazon.aws-17 SUCCESS in 13m 23s
✔️ integration-amazon.aws-18 SUCCESS in 14m 02s
✔️ integration-amazon.aws-19 SUCCESS in 28m 55s
✔️ integration-amazon.aws-20 SUCCESS in 18m 19s
✔️ integration-amazon.aws-21 SUCCESS in 22m 23s
✔️ integration-amazon.aws-22 SUCCESS in 19m 29s
✔️ integration-community.aws-1 SUCCESS in 25m 55s
✔️ integration-community.aws-2 SUCCESS in 15m 54s
✔️ integration-community.aws-3 SUCCESS in 11m 09s
✔️ integration-community.aws-4 SUCCESS in 7m 05s
✔️ integration-community.aws-5 SUCCESS in 6m 38s
✔️ integration-community.aws-6 SUCCESS in 7m 25s
✔️ integration-community.aws-7 SUCCESS in 7m 15s
✔️ integration-community.aws-8 SUCCESS in 7m 32s
✔️ integration-community.aws-9 SUCCESS in 8m 29s
✔️ integration-community.aws-10 SUCCESS in 10m 12s
✔️ integration-community.aws-11 SUCCESS in 18m 04s
✔️ integration-community.aws-12 SUCCESS in 9m 02s
Skipped 10 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3974a82 into ansible-collections:main Mar 25, 2024
40 checks passed
@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Mar 26, 2024
Copy link

patchback bot commented Mar 26, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/3974a82387a1767b648f83971a1fa60286b11e01/pr-2006

Backported as #2027

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 26, 2024
Normalize refactor

SUMMARY
fixes: #2001
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/iam.py
plugins/module_utils/transformation.py
ADDITIONAL INFORMATION
Note: also tinkers a little with Type Hinting, not sure of the value
TODO:

 Initial transform code
 Unit tests for transform code
 initial iam updates
 Basic unit tests for iam updates
 changelog

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
(cherry picked from commit 3974a82)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 1, 2024
[PR #2006/3974a823 backport][stable-7] Normalize refactor

This is a backport of PR #2006 as merged into main (3974a82).
SUMMARY
fixes: #2001
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/iam.py
plugins/module_utils/transformation.py
ADDITIONAL INFORMATION
Note: also tinkers a little with Type Hinting, not sure of the value
TODO:

 Initial transform code
 Unit tests for transform code
 initial iam updates
 Basic unit tests for iam updates
 changelog

Reviewed-by: Helen Bailey <[email protected]>
@tremble tremble deleted the normalize_refactor branch June 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor iam/boto3 "normalize" functions
3 participants