Add fail method that knows how to handle AnsibleAWSErrors #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
alinabuzachis
approved these changes
Feb 27, 2024
|
Pull request merge failed: Required status check "ansible/gate" is expected. |
tremble
force-pushed
the
modules/awserror
branch
from
2f8273f to
ca8e4d9
Compare
tremble
added
backport-7
tremble
force-pushed
the
modules/awserror
branch
from
ca8e4d9 to
9843e4b
Compare
tremble
added
mergeit
softwarefactory-project-zuul
bot
merged commit b251003
into
ansible-collections:main
39 of 41 checks passed
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2002 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
Add fail method that knows how to handle AnsibleAWSErrors SUMMARY Adds fail_json_aws_error() to AnsibeAWSModule this is just a simple wrapper around fail_json() and fail_json_aws() that knows how to route AnsibleAWSError exceptions (with and without triggering exceptions) ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/modules ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit b251003)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
) [PR #1997/b2510038 backport][stable-7] Add fail method that knows how to handle AnsibleAWSErrors This is a backport of PR #1997 as merged into main (b251003). SUMMARY Adds fail_json_aws_error() to AnsibeAWSModule this is just a simple wrapper around fail_json() and fail_json_aws() that knows how to route AnsibleAWSError exceptions (with and without triggering exceptions) ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/modules ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds fail_json_aws_error() to AnsibeAWSModule this is just a simple wrapper around fail_json() and fail_json_aws() that knows how to route AnsibleAWSError exceptions (with and without triggering exceptions)
ISSUE TYPE
COMPONENT NAME
module_utils/modules
ADDITIONAL INFORMATION