Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elb_application_lb: add support for creating alb with listener having multiple certificates #1950

Merged
merged 9 commits into from
Jan 17, 2024
Merged

elb_application_lb: add support for creating alb with listener having multiple certificates #1950

merged 9 commits into from
Jan 17, 2024

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Jan 11, 2024 •
edited
Loading

SUMMARY

Fixes #1349
This PR adds support for adding multiple certificates to a listener during Application Load Balancer creation.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elb_application_lb

ADDITIONAL INFORMATION

As per boto3 documentation

  1. only 1 certificate can be provided during call to create_listener
  2. Multiple certificates can be added using add_listener_certificates, however important to note that only 1 certificate can be specified per call.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@mandar242 mandar242 mentioned this pull request Jan 11, 2024
Closed
1 task
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f2db9c1691e44cfab7de02be23381dfd

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 15m 16s
✔️ ansible-test-splitter SUCCESS in 5m 22s
❌ integration-amazon.aws-1 FAILURE in 17m 05s
❌ integration-community.aws-1 FAILURE in 14m 24s
Skipped 42 jobs

@mandar242 mandar242 marked this pull request as draft January 11, 2024 17:21
@mandar242 mandar242 marked this pull request as ready for review January 11, 2024 17:31
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4761be9de3c44c77999613ec466e9b5c

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 14m 40s
✔️ ansible-test-splitter SUCCESS in 5m 56s
✔️ integration-amazon.aws-1 SUCCESS in 10m 48s
✔️ integration-community.aws-1 SUCCESS in 21m 48s
Skipped 42 jobs

abikouo
abikouo requested changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandar242 is it possible to update the corresponding integration test case?

changelogs/fragments/1950-elb_application_lb-multiple-listener-certificates-for-alb.yml Outdated Show resolved Hide resolved
plugins/module_utils/elbv2.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/93b0754b7f954f21bb629acfe21c1276

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 14m 48s
✔️ ansible-test-splitter SUCCESS in 5m 16s
❌ integration-amazon.aws-1 FAILURE in 10m 39s
❌ integration-community.aws-1 FAILURE in 15m 36s
Skipped 42 jobs

@mandar242 mandar242 mentioned this pull request Jan 16, 2024
Merged
@mandar242 mandar242 requested a review from abikouo January 16, 2024 04:54
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e662ccf6f1714bcd97e71ace7bbee4a8

✔️ ansible-galaxy-importer SUCCESS in 5m 11s
✔️ build-ansible-collection SUCCESS in 15m 23s
✔️ ansible-test-splitter SUCCESS in 5m 35s
❌ integration-amazon.aws-1 FAILURE in 10m 51s
✔️ integration-community.aws-1 SUCCESS in 19m 15s
Skipped 42 jobs

abikouo
abikouo approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandar242
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b7a02451023f40eb98cba7334af8f4a9

✔️ ansible-galaxy-importer SUCCESS in 4m 44s
✔️ build-ansible-collection SUCCESS in 16m 06s
✔️ ansible-test-splitter SUCCESS in 5m 15s
✔️ integration-amazon.aws-1 SUCCESS in 12m 40s
✔️ integration-community.aws-1 SUCCESS in 21m 51s
Skipped 42 jobs

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Jan 17, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/a31e642f3abf4a67a809c17257bd2277

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 14m 11s
✔️ ansible-test-splitter SUCCESS in 5m 45s
❌ integration-amazon.aws-1 RETRY_LIMIT in 7m 08s
✔️ integration-community.aws-1 SUCCESS in 28m 15s
Skipped 42 jobs

@mandar242
Copy link
Contributor Author

recheck

@mandar242 mandar242 added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Jan 17, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/ed59de166f3c4590914f48df6cdaad8d

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 15m 13s
✔️ ansible-test-splitter SUCCESS in 5m 14s
✔️ integration-amazon.aws-1 SUCCESS in 13m 14s
✔️ integration-community.aws-1 SUCCESS in 21m 08s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a41f6ad into ansible-collections:main Jan 17, 2024
37 of 42 checks passed
@mandar242 mandar242 deleted the elb_application_lb_multiple_listener_certificates branch April 26, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple listener certificates for alb
3 participants
@mandar242 @alinabuzachis @abikouo