Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1892/9e45fc20 backport][stable-7] iam_group - add support for setting the path #1898

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Dec 4, 2023

This is a backport of PR #1892 as merged into main (9e45fc2).

SUMMARY

Adds support for the 'path' option on IAM Groups.
Adds attached_policies return value.

Also refactors create_or_update_group because it was getting large and unwieldy.
Splits up test file, and adds tests for policy management

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_group

ADDITIONAL INFORMATION

iam_group - add support for setting the path

SUMMARY
Adds support for the 'path' option on IAM Groups.
Adds attached_policies return value.
Also refactors create_or_update_group because it was getting large and unwieldy.
Splits up test file, and adds tests for policy management
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_group
ADDITIONAL INFORMATION

Reviewed-by: Milan Zink <[email protected]>
Reviewed-by: Alina Buzachis
(cherry picked from commit 9e45fc2)
Copy link

github-actions bot commented Dec 4, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/563512480187420ebe4683706791f5e8

✔️ ansible-galaxy-importer SUCCESS in 5m 59s
✔️ build-ansible-collection SUCCESS in 14m 59s
✔️ ansible-test-splitter SUCCESS in 5m 49s
✔️ integration-amazon.aws-1 SUCCESS in 19m 26s
✔️ integration-amazon.aws-2 SUCCESS in 7m 46s
✔️ integration-amazon.aws-3 SUCCESS in 8m 52s
✔️ integration-amazon.aws-4 SUCCESS in 11m 36s
✔️ integration-community.aws-1 SUCCESS in 22m 56s
✔️ integration-community.aws-2 SUCCESS in 7m 24s
✔️ integration-community.aws-3 SUCCESS in 7m 52s
Skipped 37 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Dec 4, 2023
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0cda31d7d6a44a2086550840f6205e1c

✔️ ansible-galaxy-importer SUCCESS in 6m 26s
✔️ build-ansible-collection SUCCESS in 18m 46s
✔️ ansible-test-splitter SUCCESS in 7m 27s
✔️ integration-amazon.aws-1 SUCCESS in 15m 07s
✔️ integration-amazon.aws-2 SUCCESS in 7m 25s
✔️ integration-amazon.aws-3 SUCCESS in 9m 05s
✔️ integration-amazon.aws-4 SUCCESS in 10m 55s
✔️ integration-community.aws-1 SUCCESS in 24m 43s
✔️ integration-community.aws-2 SUCCESS in 46m 04s
✔️ integration-community.aws-3 SUCCESS in 22m 33s
✔️ integration-community.aws-4 SUCCESS in 17m 13s
✔️ integration-community.aws-5 SUCCESS in 19m 16s
✔️ integration-community.aws-6 SUCCESS in 16m 13s
✔️ integration-community.aws-7 SUCCESS in 5m 39s
✔️ integration-community.aws-8 SUCCESS in 17m 43s
✔️ integration-community.aws-9 SUCCESS in 13m 42s
✔️ integration-community.aws-10 SUCCESS in 24m 37s
✔️ integration-community.aws-11 SUCCESS in 9m 52s
✔️ integration-community.aws-12 SUCCESS in 9m 10s
✔️ integration-community.aws-13 SUCCESS in 11m 15s
✔️ integration-community.aws-14 SUCCESS in 9m 46s
Skipped 26 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3931fac into stable-7 Dec 4, 2023
40 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-7/9e45fc208f670466b93e932c62473c5b4c044d59/pr-1892 branch December 4, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant