Use TagSpecifications parameter when creating EC2 resources #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
ec2/resource_tags
branch
from
e63d720 to
caaad89
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
ec2/resource_tags
branch
from
caaad89 to
11fbecf
Compare
tremble
force-pushed
the
ec2/resource_tags
branch
from
11fbecf to
1cce528
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ansible_dict_to_boto3_tag_list and compare_aws_tags
…keys with "tag:" in preparation for them being used as part of a filter
alinabuzachis
approved these changes
Nov 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
regate |
|
regate |
softwarefactory-project-zuul
bot
merged commit 1b55a66
into
ansible-collections:main
39 of 40 checks passed
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #1885 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
Use TagSpecifications parameter when creating EC2 resources SUMMARY For the last couple of years Amazon's supported tagging EC2 resources as part of the creation actions. Switch the last amazon.aws EC2 modules over to using TagSpecifications during creation to support folks using Tagging requirements as part of their IAM/SCP policies ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table ec2_vpc_igw ec2_vpc_subnet ec2_eip ADDITIONAL INFORMATION fixes: #1843 Reviewed-by: Alina Buzachis (cherry picked from commit 1b55a66)
tremble
added a commit
that referenced
this pull request
Nov 29, 2023
…1885) Use TagSpecifications parameter when creating EC2 resources SUMMARY For the last couple of years Amazon's supported tagging EC2 resources as part of the creation actions. Switch the last amazon.aws EC2 modules over to using TagSpecifications during creation to support folks using Tagging requirements as part of their IAM/SCP policies ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table ec2_vpc_igw ec2_vpc_subnet ec2_eip ADDITIONAL INFORMATION fixes: #1843 Reviewed-by: Alina Buzachis (cherry picked from commit 1b55a66) Co-authored-by: Mark Chappell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For the last couple of years Amazon's supported tagging EC2 resources as part of the creation actions. Switch the last amazon.aws EC2 modules over to using TagSpecifications during creation to support folks using Tagging requirements as part of their IAM/SCP policies
ISSUE TYPE
COMPONENT NAME
ec2_vpc_route_table
ec2_vpc_igw
ec2_vpc_subnet
ec2_eip
ADDITIONAL INFORMATION
fixes: #1843