Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1844/b82c269b backport][stable-7] Tag security groups on create #1858

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 15, 2023

This is a backport of PR #1844 as merged into main (b82c269).

SUMMARY

Apply tags to security groups on create

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_security_group

ADDITIONAL INFORMATION

This fixes the issues mentioned in #1843 for security groups bu combining the resource creation and tagging into one command. This does not (at the moment) fix the same issue for other modules.

image

Tag security groups on create

SUMMARY
Apply tags to security groups on create

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_security_group
ADDITIONAL INFORMATION

This fixes the issues mentioned in #1843 for security groups bu combining the resource creation and tagging into one command. This does not (at the moment) fix the same issue for other modules.

Reviewed-by: Mark Chappell
Reviewed-by: Helen Bailey <[email protected]>
(cherry picked from commit b82c269)

This comment was marked as resolved.

@tremble
Copy link
Contributor

tremble commented Nov 16, 2023

recheck

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2d2ad9997547493ab88d7b17634809e2

✔️ ansible-galaxy-importer SUCCESS in 9m 42s
✔️ build-ansible-collection SUCCESS in 14m 04s
✔️ ansible-test-splitter SUCCESS in 5m 17s
✔️ integration-amazon.aws-1 SUCCESS in 13m 16s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Nov 16, 2023
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0223f8dc1f2c4593a783b567e6c611e8

✔️ ansible-galaxy-importer SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 14m 31s
✔️ ansible-test-splitter SUCCESS in 5m 25s
✔️ integration-amazon.aws-1 SUCCESS in 13m 06s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 989ac62 into stable-7 Nov 16, 2023
38 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-7/b82c269b768dfd77af8401664f07373f9d37bf00/pr-1844 branch November 16, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants