Revert pull request #1805 that migrated iam_server_certificate and the corresponding _info module #1819
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
force-pushed
the
revert_iam_server_certificate
branch
from
96f84da to
3af579e
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
revert_iam_server_certificate
branch
from
3af579e to
23b9f89
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 46s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 25s |
softwarefactory-project-zuul
bot
merged commit 475f800
into
ansible-collections:main
…ons#1821) Issue 1819 cloudfront distribution origin s3 domain SUMMARY Fixes ansible-collections#1819 As per Origin Domain Name spec now the S3 domain names are in the form {name}.s3.{region}.amazonaws.com, so the string fragment .s3.amazonaws.com no longer occurs in them, and therefore they aren't recognised as S3 origin domains. Consequentially, the origin is treated as a custom one, so a custom_origin_config member is generated into it, which collides with the s3_origin_config and produces an error: botocore.errorfactory.InvalidOrigin: An error occurred (InvalidOrigin) when calling the CreateDistribution operation: You must specify either a CustomOrigin or an S3Origin. You cannot specify both. The backward-compatible way is to recognise both {name}.s3.amazonaws.com and {name}.s3.{domain}.amazonaws.com, but for this a regular expression is the most effective solution. ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution ADDITIONAL INFORMATION The breakdown of the regex I used: \.s3(?:\.[^.]+)?\.amazonaws\.com$ \.s3 matches ".s3" \.[^.]+ would match a dot followed by at least one, possibly more non-dot characters (\.[^]+) would match the same, just grouped, so we could treat it as an atom (?:\.[^]+) would match the same, just grouped in a non-capturing fashion (we don't want to extract the matched characters) (?:\.[^]+)? matches the same, occuring 0 or 1 times \.amazonaws\.com matches ".amazonaws.com" $ matches the end of the input string Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis
This reverts commit 978c802, reversing changes made to 06f8f53.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION