Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ec2_vpc_net.py to allow setting ipv6_cidr: false in task. #1808

Closed
wants to merge 2 commits into from
Closed

Update ec2_vpc_net.py to allow setting ipv6_cidr: false in task. #1808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4103679
Update ec2_vpc_net.py to allow setting `ipv6_cidr: false` in task.
jscheible Oct 16, 2023
aea8fdf
Merge branch 'main' into patch-1
jscheible Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/modules/ec2_vpc_net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ def wait_for_vpc_ipv6_state(module, connection, vpc_id, ipv6_assoc_state):
If ipv6_assoc_state is False, wait for VPC to be dissociated from all Amazon-provided IPv6 CIDR blocks.
"""

if ipv6_assoc_state is None:
if not ipv6_assoc_state:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would mean that we don't wait for disassociations to complete, which would be the wrong behaviour. I suspect the bad behaviour is somewhere in the logic around line 410

return
if module.check_mode:
return
Expand Down
Loading