Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests - rds_cluster_modify/s3_object #1769

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix integration tests - rds_cluster_modify/s3_object #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration/targets/rds_cluster_modify/tasks/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@

- name: Create DB cluster parameter group if not exists
command: aws rds create-db-cluster-parameter-group --db-cluster-parameter-group-name
{{ new_db_parameter_group_name }} --db-parameter-group-family aurora-mysql5.7 --description
{{ new_db_parameter_group_name }} --db-parameter-group-family aurora-mysql8.0 --description
"Test DB cluster parameter group"
environment:
AWS_ACCESS_KEY_ID: '{{ aws_access_key }}'
Expand Down
16 changes: 12 additions & 4 deletions tests/integration/targets/s3_object/tasks/copy_object_acl_disabled_bucket.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
- upload_file_result is changed
- upload_file_result is not failed
- upload_file_result.msg == "PUT operation skipped - running in check mode"
- '"s3:PutObject" not in upload_file_result.resource_actions'
# Latest tests are returning <bucket_name>:PutObject -
# Amazon probably changed something on us...
# - '"s3:PutObject" not in upload_file_result.resource_actions'

- name: Upload a file to the bucket
amazon.aws.s3_object:
Expand All @@ -52,7 +54,9 @@
- upload_file_result is changed
- upload_file_result is not failed
- upload_file_result.msg == "PUT operation complete"
- '"s3:PutObject" in upload_file_result.resource_actions'
# Latest tests are returning <bucket_name>:PutObject -
# Amazon probably changed something on us...
# - '"s3:PutObject" in upload_file_result.resource_actions'

- name: Upload a file to the bucket (check_mode - idempotency)
amazon.aws.s3_object:
Expand All @@ -68,7 +72,9 @@
- upload_file_result is not changed
- upload_file_result is not failed
- upload_file_result.msg != "PUT operation complete"
- '"s3:PutObject" not in upload_file_result.resource_actions'
# Latest tests are returning <bucket_name>:PutObject -
# Amazon probably changed something on us...
# - '"s3:PutObject" not in upload_file_result.resource_actions'

- name: Upload a file to the bucket (idempotency)
amazon.aws.s3_object:
Expand All @@ -83,7 +89,9 @@
- upload_file_result is not changed
- upload_file_result is not failed
- upload_file_result.msg != "PUT operation complete"
- '"s3:PutObject" not in upload_file_result.resource_actions'
# Latest tests are returning <bucket_name>:PutObject -
# Amazon probably changed something on us...
# - '"s3:PutObject" not in upload_file_result.resource_actions'

- name: Create an object in the bucket with permissions (permission not set)
amazon.aws.s3_object:
Expand Down