Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yamllint cleanup/config #1745

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 6, 2023

SUMMARY

Some minor yamllint cleanup, and configuration. (Doesn't touch integration tests yet...)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

.yamllint
meta/runtime.yml
changelogs/config.yaml

ADDITIONAL INFORMATION

@tremble tremble marked this pull request as ready for review September 6, 2023 18:30
@softwarefactory-project-zuul
Copy link
Contributor

@tremble tremble added mergeit Merge the PR (SoftwareFactory) backport-6 PR should be backported to the stable-6 branch labels Sep 7, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/69eec0149b834d99bea8da46d99fefce

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 14m 03s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 520019d into ansible-collections:main Sep 7, 2023
@patchback
Copy link

patchback bot commented Sep 7, 2023

Backport to stable-6: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 520019d on top of patchback/backports/stable-6/520019de0e1e8702867bd085a6b3352383a8c0a6/pr-1745

Backporting merged PR #1745 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-6/520019de0e1e8702867bd085a6b3352383a8c0a6/pr-1745 upstream/stable-6
  4. Now, cherry-pick PR yamllint cleanup/config #1745 contents into that branch:
    $ git cherry-pick -x 520019de0e1e8702867bd085a6b3352383a8c0a6
    If it'll yell at you with something like fatal: Commit 520019de0e1e8702867bd085a6b3352383a8c0a6 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 520019de0e1e8702867bd085a6b3352383a8c0a6
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR yamllint cleanup/config #1745 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-6/520019de0e1e8702867bd085a6b3352383a8c0a6/pr-1745
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

tremble added a commit to tremble/amazon.aws that referenced this pull request Sep 7, 2023
yamllint cleanup/config

SUMMARY
Some minor yamllint cleanup, and configuration. (Doesn't touch integration tests yet...)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
.yamllint
meta/runtime.yml
changelogs/config.yaml
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 7, 2023
[backport][stable-6] yamllint cleanup/config (#1745)

SUMMARY
Some minor yamllint cleanup, and configuration. (Doesn't touch integration tests yet...)
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
.yamllint
meta/runtime.yml
changelogs/config.yaml
ADDITIONAL INFORMATION
Reviewed-by: Alina Buzachis

Reviewed-by: Alina Buzachis
abikouo added a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…red ec2 instances (ansible-collections#1745)

ssm_inventory_info module

SUMMARY

new module to retrieve ssm inventory info for EC2 configured instances

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ssm_inventory_info

Reviewed-by: Mark Chappell
abikouo added a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…red ec2 instances (ansible-collections#1745)

ssm_inventory_info module

SUMMARY

new module to retrieve ssm inventory info for EC2 configured instances

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ssm_inventory_info

Reviewed-by: Mark Chappell
@tremble tremble deleted the 20230906/ansible-lint branch September 27, 2023 07:01
abikouo added a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…red ec2 instances (ansible-collections#1745)

ssm_inventory_info module

SUMMARY

new module to retrieve ssm inventory info for EC2 configured instances

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ssm_inventory_info

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory) skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants