[PR #1582/ee68be3d backport][stable-6] aws_ec2 inventory : Modify accepted type for hostnames argument in the module doc #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…e module doc (#1582) aws_ec2 inventory : Modify accepted type for hostnames argument in the module doc SUMMARY Fixes #1460 The argument hostnames is of type list, whose elements can be string and dict. ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit ee68be3)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 12s |
alinabuzachis
approved these changes
Jun 5, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 09s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-6/ee68be3d7221b76e3bff2ecd047b5eabc62faf46/pr-1582
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
eks_cluster: adding tags to eks cluster SUMMARY As described by issue ansible-collections#1513 All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_eks_cluster ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Amir <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
eks_cluster: adding tags to eks cluster SUMMARY As described by issue ansible-collections#1513 All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_eks_cluster ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Amir <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
eks_cluster: adding tags to eks cluster SUMMARY As described by issue ansible-collections#1513 All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_eks_cluster ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Amir <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1582 as merged into main (ee68be3).
SUMMARY
Fixes #1460
The argument
hostnamesis of type list, whose elements can be string and dict.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION