Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1464/1f1ac75a backport][stable-6] ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions #1546

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 11, 2023

This is a backport of PR #1464 as merged into main (1f1ac75).

SUMMARY
  1. Add support for modifying and resetting snapshot share permissions (createVolumePermissions) of a ec2 snapshot to amazon.aws.ec2_snapshot.
  2. Add ec2 snapshot's snapshot share permissions (createVolumePermissions) to return value of amazon.aws.ec2_snapshot_info.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

amazon.aws.ec2_snapshot
amazon.aws.ec2_snapshot_info

ADDITIONAL INFORMATION

API references

describe_snapshot_attribute
modify_snapshot_attribute
reset_snapshot_attribute

… permissions (#1464)

ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions

SUMMARY

Add support for modifying and resetting snapshot share permissions (createVolumePermissions) of a ec2 snapshot to amazon.aws.ec2_snapshot.
Add ec2 snapshot's snapshot share permissions (createVolumePermissions) to return value of amazon.aws.ec2_snapshot_info.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

amazon.aws.ec2_snapshot
amazon.aws.ec2_snapshot_info
ADDITIONAL INFORMATION

API references

describe_snapshot_attribute
modify_snapshot_attribute
reset_snapshot_attribute

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
(cherry picked from commit 1f1ac75)
@github-actions
Copy link

github-actions bot commented May 11, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/dcb68380691f4c0bbcb582624c22312d

✔️ ansible-galaxy-importer SUCCESS in 3m 53s
✔️ build-ansible-collection SUCCESS in 12m 18s
✔️ ansible-test-splitter SUCCESS in 4m 34s
✔️ integration-amazon.aws-1 SUCCESS in 16m 46s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 12, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/1db51f5a43534bb3b8f310c120641272

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 12m 22s
✔️ ansible-test-splitter SUCCESS in 4m 45s
✔️ integration-amazon.aws-1 SUCCESS in 17m 02s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6698cdd into stable-6 May 12, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-6/1f1ac75a4ac85635359be906d150a75d8a9fbb78/pr-1464 branch May 12, 2023 08:03
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request May 19, 2023
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 19, 2023
…odify snapshotot share permissions (#1464) (#1546)" (#1560)

Temporarily Revert "ec2_snapshot, ec2_snapshot_info: Add support to modify snapshotot share permissions (#1464) (#1546)"

Temporarily Revert "ec2_snapshot, ec2_snapshot_info: Add support to modify snapshotot share permissions (#1464) (#1546)"
This reverts commit 6698cdd.
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
… list of dicts (ansible-collections#1643)

[6.0.0] codebuild_project - update tags param to use dict rather than list of dicts

SUMMARY
Passing list of dicts was deprecated, move it to dict
fixes: ansible-collections#1546
Originally deprecated in ansible-collections#1221 as part of the tagging cleanup.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
codebuild_project
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
… list of dicts (ansible-collections#1643)

[6.0.0] codebuild_project - update tags param to use dict rather than list of dicts

SUMMARY
Passing list of dicts was deprecated, move it to dict
fixes: ansible-collections#1546
Originally deprecated in ansible-collections#1221 as part of the tagging cleanup.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
codebuild_project
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
… list of dicts (ansible-collections#1643)

[6.0.0] codebuild_project - update tags param to use dict rather than list of dicts

SUMMARY
Passing list of dicts was deprecated, move it to dict
fixes: ansible-collections#1546
Originally deprecated in ansible-collections#1221 as part of the tagging cleanup.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
codebuild_project
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants