[PR #1531/800ed8d5 backport][stable-5] ec2_vpc_endpoint - test flake #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ec2_vpc_endpoint - test flake SUMMARY Test was assuming that an endpoint we might not have created had no routes attached. This makes the test flaky when things are run in parallel. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_endpoint ADDITIONAL INFORMATION Routes (existence or not) are tested in later tests where we know which endpoint we're looking at. Reviewed-by: Alina Buzachis (cherry picked from commit 800ed8d)
tremble
approved these changes
May 8, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 47s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/800ed8d583d3b9a3502d1a549f93e9277bdeeac6/pr-1531
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate rds_subnet_group* modules and tests Depends-On: ansible-collections#1058 Remove rds_subnet_group* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate rds_subnet_group* modules and tests Depends-On: ansible-collections#1058 Remove rds_subnet_group* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Migrate rds_subnet_group* modules and tests Depends-On: ansible-collections#1058 Remove rds_subnet_group* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1531 as merged into main (800ed8d).
SUMMARY
Test was assuming that an endpoint we might not have created had no routes attached. This makes the test flaky when things are run in parallel.
ISSUE TYPE
COMPONENT NAME
ec2_vpc_endpoint
ADDITIONAL INFORMATION
Routes (existence or not) are tested in later tests where we know which endpoint we're looking at.