Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-5] [backport/1511] s3_bucket - Ensure public_access settings are configured before policies #1512

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 4, 2023

Manual backport of #1511

SUMMARY

At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced". https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ This uncovered a race condition where we set the policy before setting the public_access configs

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_bucket

ADDITIONAL INFORMATION

…ies (ansible-collections#1511)

s3_bucket - Ensure public_access settings are configured before policies

SUMMARY
At the end of April Amazon updated various S3 bucket defaults.  Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced".
https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/
This uncovered a race condition where we set the policy before setting the public_access configs.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
@tremble tremble requested a review from alinabuzachis May 4, 2023 11:48
@tremble tremble added this to the 5.5.0 milestone May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble marked this pull request as ready for review May 4, 2023 11:57
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/bc7f38c221554aa689f82a7e9f81d9c3

✔️ ansible-galaxy-importer SUCCESS in 3m 30s
✔️ build-ansible-collection SUCCESS in 13m 07s
✔️ ansible-test-splitter SUCCESS in 5m 11s
✔️ integration-amazon.aws-1 SUCCESS in 8m 26s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/f0e270124d5c4950936fe976c3eda529

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 12m 47s
✔️ ansible-test-splitter SUCCESS in 5m 49s
✔️ integration-amazon.aws-1 SUCCESS in 8m 22s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit fcf0df4 into ansible-collections:stable-5 May 4, 2023
@tremble tremble deleted the backport/stable-5/1511 branch September 27, 2023 07:00
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
SUMMARY

Add rendered Changelog to the docs site

ISSUE TYPE

-  Docs Pull Request

COMPONENT NAME

README.md
docs/docsite/extra-docs.yml
docs/docsite/rst/CHANGELOG.rst

ADDITIONAL INFORMATION

Related to ansible-community/community-team#61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants