Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment on permission because of botocore.exceptions.ClientError: An error occurred (AccessControlListNotSupported) when calling the PutObject operation: The bucket does not allow ACLs #1502

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

Comment on permission because of botocore.exceptions.ClientError: An error occurred (AccessControlListNotSupported) when calling the PutObject operation: The bucket does not allow ACLs

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

…error occurred (AccessControlListNotSupported) when calling the PutObject operation: The bucket does not allow ACLs

Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5890f0d54303412891046a9794757edc

✔️ ansible-galaxy-importer SUCCESS in 3m 43s
✔️ build-ansible-collection SUCCESS in 12m 38s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 8m 41s
Skipped 43 jobs

@alinabuzachis alinabuzachis added the backport-5 PR should be backported to the stable-5 branch label May 2, 2023
@alinabuzachis
Copy link
Collaborator Author

I have opened an issue for this #1503

@@ -45,7 +45,7 @@
bucket: "{{ s3_bucket_name }}"
mode: put
object: "{{ s3_bucket_object }}"
permission: public-read
# permission: public-read # Commented on because botocore.exceptions.ClientError: An error occurred (AccessControlListNotSupported) when calling the PutObject operation: The bucket does not allow ACLs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file an issue for us to come back and setup the bucket permissions correctly so that we can test the permissions key for objects? I understand we want to unblock CI for the release in the short term but we should also fix this in the mid term.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry I just saw your recent previous comment, I had this PR open too long! :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jillr Have filed this issue #1503

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label May 2, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/1b74a96078a24d3cbddecfb6719b0c9b

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 12m 55s
✔️ ansible-test-splitter SUCCESS in 5m 01s
✔️ integration-amazon.aws-1 SUCCESS in 7m 40s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7ae909b into ansible-collections:main May 2, 2023
@patchback
Copy link

patchback bot commented May 2, 2023

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 7ae909b on top of patchback/backports/stable-5/7ae909b34ec8f9afff534fb7a8597c15b03821c3/pr-1502

Backporting merged PR #1502 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-5/7ae909b34ec8f9afff534fb7a8597c15b03821c3/pr-1502 upstream/stable-5
  4. Now, cherry-pick PR Comment on permission because of botocore.exceptions.ClientError: An error occurred (AccessControlListNotSupported) when calling the PutObject operation: The bucket does not allow ACLs #1502 contents into that branch:
    $ git cherry-pick -x 7ae909b34ec8f9afff534fb7a8597c15b03821c3
    If it'll yell at you with something like fatal: Commit 7ae909b34ec8f9afff534fb7a8597c15b03821c3 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 7ae909b34ec8f9afff534fb7a8597c15b03821c3
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Comment on permission because of botocore.exceptions.ClientError: An error occurred (AccessControlListNotSupported) when calling the PutObject operation: The bucket does not allow ACLs #1502 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-5/7ae909b34ec8f9afff534fb7a8597c15b03821c3/pr-1502
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5 PR should be backported to the stable-5 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants