[manual backport stable-5] rds - add the engine_mode parameter (#941) #1493
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 42s |
|
recheck |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 06s |
|
recheck |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 55s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 02s |
alinabuzachis
force-pushed
the
backport_941
branch
from
8074744 to
bcfa80b
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 51s |
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Alina Buzachis <None>
Signed-off-by: Alina Buzachis <[email protected]>
|
PR looks a little weird now, as far as I can tell, some of it got pulled in with #1491 |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 39s |
|
recheck |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 59s |
softwarefactory-project-zuul
bot
merged commit 50845b0
into
ansible-collections:stable-5
Fix rds_cluster tests on stable-5 branch SUMMARY This fixes two problems with the rds_cluster test target. Ansible 2.16 is removing ansible.builtin.include (and has removed it in the current milestone branch), so this has been replaced with ansible.builtin.include_tasks. In addition, this updates the engine as Aurora 1 has been retired. I'm a little confused by the history of this test target. #1493 and #1504 seem to have been merged on the same day, with one overwriting some of the changes of the other. The tests for rds_cluster on the stable-5 branch are currently broken, though, as can be seen in the failure on #1664. If there's a better way to fix this, feel free to suggest something different. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Jill R Reviewed-by: Alina Buzachis
rds - add the engine_mode parameter
Depends-On: #1185
Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes:
With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted)
The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests.
Reviewed-by: Gonéri Le Bouder [email protected]
Reviewed-by: Alina Buzachis
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION