Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure boto3 verify parameter isn't overridden by setting a profile #147

Merged
merged 4 commits into from
Aug 26, 2020

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 20, 2020

fixes: #129

SUMMARY

If, in your playbook, you set

validate_certs: False
profile: profile_name_here

the code would set boto_params['verify'] = validate_certs but then immediately afterwards, overwrite that with boto_params = dict(aws_access_key_id=None, aws_secret_access_key=None, aws_session_token=None) That would mean the default boto3 value of verify is used instead of the value set in the playbook.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/ec2.py

ADDITIONAL INFORMATION

@abadger
Copy link

abadger commented Aug 20, 2020

This looks good to me!

@jillr jillr merged commit cb2f0d6 into ansible-collections:main Aug 26, 2020
@tremble tremble deleted the issues/129 branch May 28, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2 verify parameter is overridden if profile is set and we're using boto3
3 participants