Disable S3 tests related to removing bucket encryption #1395
Conversation
tremble
added
backport-4
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 54s |
There was a problem hiding this comment.
@tremble Shouldn't we also add a note in module's documentation?
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Added a note. Since we support other clouds I'm not going to remove "none" as an option. |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 30s |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1397 🤖 @patchback |
Disable S3 tests related to removing bucket encryption SUMMARY Amazon now enables S3-SSE bucket encryption by default and it's not possible to disable it. Disable the relevant tests but leave a minimal framework in place. ISSUE TYPE Tests Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 15d92a7)
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1398 🤖 @patchback |
Disable S3 tests related to removing bucket encryption SUMMARY Amazon now enables S3-SSE bucket encryption by default and it's not possible to disable it. Disable the relevant tests but leave a minimal framework in place. ISSUE TYPE Tests Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 15d92a7)
[PR #1395/15d92a74 backport][stable-4] Disable S3 tests related to removing bucket encryption This is a backport of PR #1395 as merged into main (15d92a7). SUMMARY Amazon now enables S3-SSE bucket encryption by default and it's not possible to disable it. Disable the relevant tests but leave a minimal framework in place. ISSUE TYPE Tests Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
[PR #1395/15d92a74 backport][stable-5] Disable S3 tests related to removing bucket encryption This is a backport of PR #1395 as merged into main (15d92a7). SUMMARY Amazon now enables S3-SSE bucket encryption by default and it's not possible to disable it. Disable the relevant tests but leave a minimal framework in place. ISSUE TYPE Tests Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
s3_bucket: object lock enabled Depends-On: ansible-collections#1395 SUMMARY Fixes ansible-collections#1347 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
cloudwatchlogs: Condense cloudwatch tests SUMMARY Merging tests for cloudwatchlogs and cloudwatchlogs_log_group into combined suite cloudwatchlogs. There are 2 test suites in community.aws with substantially overlapping functionality - cloudwatchlogs and cloudwatch_log_group. The cloudwatchlogs runs for changes to the cloudwatchlogs_log_group and cloudwatchlogs_log_group_metric_filter modules, and the cloudwatch_log_group only runs for cloudwatchlogs_log_group_info. Merging the 2 test suites to create a combined suite for testing the overlapping functionalities could be a good idea. ISSUE TYPE Feature Pull Request COMPONENT NAME cloudwatchlogs cloudwatchlogs_log_group Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9660de0
cloudwatchlogs: Condense cloudwatch tests SUMMARY Merging tests for cloudwatchlogs and cloudwatchlogs_log_group into combined suite cloudwatchlogs. There are 2 test suites in community.aws with substantially overlapping functionality - cloudwatchlogs and cloudwatch_log_group. The cloudwatchlogs runs for changes to the cloudwatchlogs_log_group and cloudwatchlogs_log_group_metric_filter modules, and the cloudwatch_log_group only runs for cloudwatchlogs_log_group_info. Merging the 2 test suites to create a combined suite for testing the overlapping functionalities could be a good idea. ISSUE TYPE Feature Pull Request COMPONENT NAME cloudwatchlogs cloudwatchlogs_log_group Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Jill R <None>
SUMMARY
Amazon now enables S3-SSE bucket encryption by default and it's not possible to disable it. Disable the relevant tests but leave a minimal framework in place.
ISSUE TYPE
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION