aws_collection_constants #1344
Merged
aws_collection_constants #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
integration
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
abikouo
reviewed
Jan 24, 2023
Comment on lines
+75
to
+76
| if not terms: | ||
| raise AnsibleLookupError("Constant name not provided") |
There was a problem hiding this comment.
instead of raising an error, why not return all constant values?
this needs to change the return format as dictionnary
There was a problem hiding this comment.
I couldn't think of a use case where we'd want to dump out all of them, so was trying to follow the KISS Principle
alinabuzachis
approved these changes
Jan 24, 2023
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#1344) kms_key - Finish deprecation of policy_grant_types and related keys SUMMARY Managing the KMS IAM Policy via policy_mode and policy_grant_types was fragile and previously deprecated. Complete the deprecation and remove the options in in favour of the policy option. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/kms_key.py ADDITIONAL INFORMATION Original deprecation: ansible/ansible#60561 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#1344) kms_key - Finish deprecation of policy_grant_types and related keys SUMMARY Managing the KMS IAM Policy via policy_mode and policy_grant_types was fragile and previously deprecated. Complete the deprecation and remove the options in in favour of the policy option. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/kms_key.py ADDITIONAL INFORMATION Original deprecation: ansible/ansible#60561 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#1344) kms_key - Finish deprecation of policy_grant_types and related keys SUMMARY Managing the KMS IAM Policy via policy_mode and policy_grant_types was fragile and previously deprecated. Complete the deprecation and remove the options in in favour of the policy option. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/kms_key.py ADDITIONAL INFORMATION Original deprecation: ansible/ansible#60561 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a simple lookup plugin to retrieve some of the constants in the collection
ISSUE TYPE
COMPONENT NAME
plugins/lookup/aws_collection_constants.py
ADDITIONAL INFORMATION
This means we've one less place we need to update when bumping the supported botocore version.