-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_vpc_dhcp_option - retry describe_dhcp_options on InvalidDhcpOptioID.NotFound #1320
Merged
softwarefactory-project-zuul
merged 2 commits into
ansible-collections:main
from
tremble:tests/stability/ec2_vpc_dhcp_option
Jan 5, 2023
Merged
ec2_vpc_dhcp_option - retry describe_dhcp_options on InvalidDhcpOptioID.NotFound #1320
softwarefactory-project-zuul
merged 2 commits into
ansible-collections:main
from
tremble:tests/stability/ec2_vpc_dhcp_option
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nID.NotFound While we're returned the ID, creation and propagation isn't always instance. Allow retries after creation
ansibullbot
added
bug
This issue/PR relates to a bug
community_review
integration
tests/integration
module
module
needs_triage
plugins
plugin (any type)
tests
tests
labels
Jan 5, 2023
alinabuzachis
approved these changes
Jan 5, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
community_review
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Integration tests have been flakey because of
While we're returned the ID, creation and propagation isn't always instant. Allow for retries after creation of an optionset.
ISSUE TYPE
COMPONENT NAME
ec2_vpc_dhcp_options
ADDITIONAL INFORMATION
Examples:
https://99b800ba2f338f8fe26c-b9e663698c5137b7c40d5b983da05750.ssl.cf5.rackcdn.com/1310/8b18a5ca6e49e02b0004c86cc3467e10b0757555/gate/integration-amazon.aws-16/23f54a3/job-output.txt
https://530531024c51fb0860cd-d325a0cf1bd8249f2d5115b3e7ba100c.ssl.cf5.rackcdn.com/1310/8b18a5ca6e49e02b0004c86cc3467e10b0757555/gate/integration-amazon.aws-16/3594443/job-output.txt
(note the failing ec2_vpc_net test is actually the DHCP option creation failing. First time we get the exception, second time the option already exists so isn't "changed")