[PR #1266/e56003e3 backport][stable-5] rds_instance: support for gp3 #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
1 similar comment
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
@markuman I seem to recall that the rds_instance tests were pretty slow until they were reworked, I'm guessing we need to backport the test updates. |
|
@markuman @alinabuzachis I've backported the test changes as #1324 hopefully that'll make it easier to backport this PR. |
rds_instance: support for gp3 SUMMARY Fixes: #1254 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Required boto3 >= 1.26.0 Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <[email protected]> (cherry picked from commit e56003e)
tremble
force-pushed
the
patchback/backports/stable-5/e56003e341f9ba37ff5e7aa77ca44f228155ec6d/pr-1266
branch
from
8b6fdd9 to
adf774f
Compare
tremble
approved these changes
Jan 10, 2023
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/e56003e341f9ba37ff5e7aa77ca44f228155ec6d/pr-1266
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1266 as merged into main (e56003e).
SUMMARY
Fixes: #1254
ISSUE TYPE
COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
Required boto3 >= 1.26.0