-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #1145/7b0d9645 backport][stable-5] Enable ec2_metadata integration tests #1149
Merged
tremble
merged 1 commit into
stable-5
from
patchback/backports/stable-5/7b0d9645c3d2fbb6ee24007caebd91c9e4a61e7c/pr-1145
Oct 11, 2022
Merged
[PR #1145/7b0d9645 backport][stable-5] Enable ec2_metadata integration tests #1149
tremble
merged 1 commit into
stable-5
from
patchback/backports/stable-5/7b0d9645c3d2fbb6ee24007caebd91c9e4a61e7c/pr-1145
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable ec2_metadata integration tests SUMMARY Enable ec2_metadata_facts integration tests ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metadata_facts ADDITIONAL INFORMATION As shown by #1138 we should try to ensure that the integration tests are enabled Reviewed-by: Alina Buzachis <None> (cherry picked from commit 7b0d964)
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
tests
tests
labels
Oct 10, 2022
tremble
approved these changes
Oct 11, 2022
This comment was marked as resolved.
This comment was marked as resolved.
tremble
approved these changes
Oct 11, 2022
@goneri there's something flaky going on with the changelog test. You can clearly see that there is a changelog attached to this PR. |
tremble
deleted the
patchback/backports/stable-5/7b0d9645c3d2fbb6ee24007caebd91c9e4a61e7c/pr-1145
branch
October 11, 2022 18:10
Failed test is changelog which appears to be flaky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1145 as merged into main (7b0d964).
SUMMARY
Enable ec2_metadata_facts integration tests
ISSUE TYPE
COMPONENT NAME
ec2_metadata_facts
ADDITIONAL INFORMATION
As shown by #1138 we should try to ensure that the integration tests are enabled