Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand tagging unit tests #1147

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Expand tagging unit tests #1147

merged 1 commit into from
Oct 10, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 10, 2022

SUMMARY

Catch a couple of extra, simple, cases in the tagging unit tests

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/tagging.py

ADDITIONAL INFORMATION

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_triage tests tests labels Oct 10, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 6m 46s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 01s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 22s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 22s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 41s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 16s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 21s
✔️ cloud-tox-py3 SUCCESS in 4m 45s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 10, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 5m 06s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 29s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 22s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 53s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 41s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 16s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 27s
✔️ cloud-tox-py3 SUCCESS in 3m 41s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ffd8f84 into ansible-collections:main Oct 10, 2022
@tremble tremble deleted the tests/module_utils/tagging branch October 21, 2022 07:33
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
ec2_transit_gateway_vpc_attachment - retry on IncorrectState (ansible…
3347cb0 
…-collections#1147)

ec2_transit_gateway_vpc_attachment - retry on IncorrectState

SUMMARY
Follows on from ansible-collections#1110 - to retry ec2_transit_gateway_vpc_attachment failures
Doing this separately because it's not in the stable-3 branch.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_transit_gateway_vpc_attachment
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 18, 2024
@tremble @alinabuzachis
ec2_transit_gateway_vpc_attachment - retry on IncorrectState (ansible…
146535f 
…-collections#1147)

ec2_transit_gateway_vpc_attachment - retry on IncorrectState

SUMMARY
Follows on from ansible-collections#1110 - to retry ec2_transit_gateway_vpc_attachment failures
Doing this separately because it's not in the stable-3 branch.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_transit_gateway_vpc_attachment
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3347cb0
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 23, 2024
@tremble @alinabuzachis
ec2_transit_gateway_vpc_attachment - retry on IncorrectState (ansible…
a66ff16 
…-collections#1147)

ec2_transit_gateway_vpc_attachment - retry on IncorrectState

SUMMARY
Follows on from ansible-collections#1110 - to retry ec2_transit_gateway_vpc_attachment failures
Doing this separately because it's not in the stable-3 branch.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_transit_gateway_vpc_attachment
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3347cb0
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @alinabuzachis
ec2_transit_gateway_vpc_attachment - retry on IncorrectState (ansible…
7a85303 
…-collections#1147)

ec2_transit_gateway_vpc_attachment - retry on IncorrectState

SUMMARY
Follows on from ansible-collections#1110 - to retry ec2_transit_gateway_vpc_attachment failures
Doing this separately because it's not in the stable-3 branch.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_transit_gateway_vpc_attachment
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@3347cb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@goneri goneri Awaiting requested review from goneri

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_triage tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @alinabuzachis @ansibullbot