Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1138/c269898a backport][stable-5] Fix AttributeError when running ec2_metadata_facts #1141

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 10, 2022

This is a backport of PR #1138 as merged into main (c269898).

SUMMARY

Prior to 5.0.0 we caught "Exception" within fetch, this was limited to json.JSONDecodeError, however it looks like we also needed to catch AttributeError for non-dict JSON

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_metadata_facts

ADDITIONAL INFORMATION

fixes: #1134

Fix AttributeError when running ec2_metadata_facts

SUMMARY
Prior to 5.0.0 we caught "Exception" within fetch, this was limited to json.JSONDecodeError, however it looks like we also needed to catch AttributeError for non-dict JSON
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_metadata_facts
ADDITIONAL INFORMATION
fixes: #1134

(cherry picked from commit c269898)
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 10, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Oct 10, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 5m 34s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 41s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 50s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 46s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 21s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 01s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 32s
✔️ cloud-tox-py3 SUCCESS in 3m 20s
✔️ ansible-test-splitter SUCCESS in 2m 57s
✔️ integration-amazon.aws-1 SUCCESS in 5m 54s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 22s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6a3acb1 into stable-5 Oct 10, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/c269898a50ade92f7e62607ff9e25c05d7f37ffd/pr-1138 branch October 10, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants