ec2_metadata_facts: avoid an AttributeError #1140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ami-launch-index` return an `int`. `json.load()` returns the same value and the same type. This was causing an `AttributeError` exception later in the code. We now properly address the exception. The commit also reenables the functional test.
goneri
force-pushed
the
ec2_metadata_facts-avoid-an-AttributeError_11259
branch
from
7755fc9 to
92b3372
Compare
ansibullbot
added
community_review
integration
|
See: #1138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ami-launch-indexreturn anint.json.load()returns the samevalue and the same type. This was causing an
AttributeErrorexceptionlater in the code.
We now properly address the exception.
The commit also re-enables the functional test.