Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inventory/aws_ec2: drop := operator because we still support py3.6 #1098

Conversation

goneri
Copy link
Member

@goneri goneri commented Oct 3, 2022

Depends-On: ansible/ansible-zuul-jobs#1649
Depends-On: #1100

The operator was included with Python 3.8.

See: https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions

@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot ansibullbot added inventory inventory plugin needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) python3 small_patch Hopefully easy to review labels Oct 3, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 47s
✔️ build-ansible-collection SUCCESS in 6m 37s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 06s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 42s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 13s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 14s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 11s
✔️ cloud-tox-py3 SUCCESS in 2m 43s
✔️ ansible-test-splitter SUCCESS in 4m 07s
✔️ integration-amazon.aws-1 SUCCESS in 46m 49s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 30s

@goneri
Copy link
Member Author

goneri commented Oct 3, 2022

recheck

@goneri goneri requested a review from alinabuzachis October 3, 2022 16:06
@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

@goneri
Copy link
Member Author

goneri commented Oct 3, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

@goneri
Copy link
Member Author

goneri commented Oct 3, 2022

recheck

@goneri goneri mentioned this pull request Oct 3, 2022
@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label Oct 3, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 13s
✔️ build-ansible-collection SUCCESS in 4m 52s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 43s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 29s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 07s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 33s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 52s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 40s
✔️ cloud-tox-py3 SUCCESS in 2m 48s
✔️ ansible-test-splitter SUCCESS in 2m 57s
✔️ integration-amazon.aws-1 SUCCESS in 51m 20s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 19s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ea44066 into ansible-collections:main Oct 3, 2022
markuman pushed a commit to markuman/amazon.aws that referenced this pull request Oct 5, 2022
iam_user - remove duplicate method

SUMMARY
Remove duplicate method delete_user_login_profile, as there is already a delete_login_profile method
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_user

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@2a84777
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
iam_user - remove duplicate method

SUMMARY
Remove duplicate method delete_user_login_profile, as there is already a delete_login_profile method
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_user

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
iam_user - remove duplicate method

SUMMARY
Remove duplicate method delete_user_login_profile, as there is already a delete_login_profile method
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_user

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
iam_user - remove duplicate method

SUMMARY
Remove duplicate method delete_user_login_profile, as there is already a delete_login_profile method
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_user

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inventory inventory plugin mergeit Merge the PR (SoftwareFactory) needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) python3 small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants