Make example AWS UUIDS follow a specific pattern #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
docs
integration
alinabuzachis
approved these changes
Sep 27, 2022
This comment was marked as outdated.
This comment was marked as outdated.
|
@tremble changelog needed! |
This comment was marked as outdated.
This comment was marked as outdated.
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Sep 28, 2022
Split from ansible-collections#1070 due to test concurrency problems
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
regate |
This comment was marked as outdated.
This comment was marked as outdated.
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
Make example AWS UUIDS follow a specific pattern - RDS SUMMARY Various AWS IAM resources have UUID which follow a specific pattern. Similarly AWS accounts are all 12 digit numbers (text aliases in a couple of cases). To minimize the risk of accidental data leaks use a consistent Account ID in examples (123456789012), and a specific format for the UUIDS: (AKIA|AGPA|AIDA|AROA|AIPA|ANPA|ANVA|ASIA)12345EXAMPLE54321 While this does nothing about historic data, having consistency makes it easier to prevent future leaks. Note: We should follow this up with an update to the developer docs, however I'd like to get this in prior to 5.0.0 Split from #1070 due to test concurrency problems ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/rds_instance_info.py plugins/modules/rds_option_group.py plugins/modules/rds_option_group_info.py plugins/modules/rds_snapshot_info.py plugins/modules/rds_subnet_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
|
regate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Various AWS IAM resources have UUID which follow a specific pattern. Similarly AWS accounts are all 12 digit numbers (text aliases in a couple of cases). To minimize the risk of accidental data leaks use a consistent Account ID in examples (
123456789012), and a specific format for the UUIDS:(AKIA|AGPA|AIDA|AROA|AIPA|ANPA|ANVA|ASIA)12345EXAMPLE54321While this does nothing about historic data, having consistency makes it easier to prevent future leaks.
Note: We should follow this up with an update to the developer docs, however I'd like to get this in prior to 5.0.0
ISSUE TYPE
COMPONENT NAME
plugins/modules/autoscaling_group_info.py
plugins/modules/cloudformation.py
plugins/modules/ec2_ami.py
plugins/modules/ec2_ami_info.py
plugins/modules/ec2_eni_info.py
plugins/modules/ec2_instance.py
plugins/modules/ec2_instance_info.py
plugins/modules/ec2_metadata_facts.py
plugins/modules/ec2_security_group.py
plugins/modules/ec2_security_group_info.py
plugins/modules/ec2_snapshot_info.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_application_lb_info.py
plugins/modules/iam_user_info.py
plugins/modules/kms_key.py
plugins/modules/kms_key_info.py
plugins/modules/lambda.py
plugins/modules/rds_instance_info.py
plugins/modules/rds_option_group.py
plugins/modules/rds_option_group_info.py
plugins/modules/rds_snapshot_info.py
plugins/modules/rds_subnet_group.py
ADDITIONAL INFORMATION
While the 'secret' nature of these UUIDs is debatable (they're closer to user names than passwords), deliberately mangling them makes it easier for InfoSec teams to spot when their secret counterparts may have been leaked in combination with a real 'public' part.