Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add unit-tests for calculate_etag() #1015

Merged
merged 1 commit into from
Sep 12, 2022
Merged

tests: add unit-tests for calculate_etag() #1015

merged 1 commit into from
Sep 12, 2022

Conversation

goneri
Copy link
Member

@goneri goneri commented Sep 12, 2022 •
edited
Loading

Add test coverage for calucalte_etag that cover the two cases (with or without multipart).

@goneri goneri mentioned this pull request Sep 12, 2022
Closed
1 task
@goneri goneri force-pushed the tests-add-unit-tests-for-calculate_etag_23930 branch from 3a6e8c4 to 36215b6 Compare September 12, 2022 18:54
@goneri goneri closed this Sep 12, 2022
@goneri goneri reopened this Sep 12, 2022
@goneri
Copy link
Member Author

goneri commented Sep 12, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 5m 39s
✔️ build-ansible-collection SUCCESS in 5m 15s
❌ ansible-test-sanity-aws-ansible-python38 FAILURE in 8m 19s
❌ ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 9m 21s
❌ ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 9m 30s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 37s

@goneri
tests: add unit-tests for calculate_etag()
4ba7a73 
Add test coverage for `calucalte_etag` that cover the two cases
(with or without multipart).
@goneri goneri force-pushed the tests-add-unit-tests-for-calculate_etag_23930 branch from 36215b6 to 4ba7a73 Compare September 12, 2022 20:06
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 51s
✔️ build-ansible-collection SUCCESS in 5m 44s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 53s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 23s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 47s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 56s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 4m 57s

@goneri goneri requested a review from tremble September 12, 2022 20:29
@jillr jillr added the gate label Sep 12, 2022
@goneri goneri added mergeit Merge the PR (SoftwareFactory) and removed gate labels Sep 12, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 5m 35s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 55s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 11s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 34s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 57s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 58s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ad9ddf3 into ansible-collections:main Sep 12, 2022
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@marknet15
Fix introduced bug (ansible-collections#1015)
6f4f417 
Fix introduced bug in elb_target_group_info

SUMMARY
Fix bug introduced here: ansible-collections#1001
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
elb_target_group_info
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@marknet15 @abikouo
Fix introduced bug (ansible-collections#1015)
b6b71a1 
Fix introduced bug in elb_target_group_info

SUMMARY
Fix bug introduced here: ansible-collections#1001
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
elb_target_group_info
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@marknet15
Fix introduced bug (ansible-collections#1015)
be4a4a2 
Fix introduced bug in elb_target_group_info

SUMMARY
Fix bug introduced here: ansible-collections#1001
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
elb_target_group_info
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

@tremble tremble Awaiting requested review from tremble

Assignees
No one assigned
Labels
community_review has_issue mergeit Merge the PR (SoftwareFactory) needs_triage tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goneri @jillr @ansibullbot