Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent spot instances need stopping ability #61

Closed
jeyrichman opened this issue Jun 3, 2020 · 6 comments
Closed

Persistent spot instances need stopping ability #61

jeyrichman opened this issue Jun 3, 2020 · 6 comments
Labels
affects_2.10 backlog feature This issue/PR relates to a feature request needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly spot waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@jeyrichman
Copy link

Hi, I want to be able to stop spot instances like I can do via AWS CLI, AWS SDKs, AWS CloudFormation, AWS Lambda.
This is described here:
https://aws.amazon.com/about-aws/whats-new/2017/09/amazon-ec2-spot-can-now-stop-and-start-your-spot-instances/

And I believe the following needs to be updated:

amazon.aws/plugins/modules/ec2.py

Line 1208 in 629b890

# You can't tell spot instances to 'stop'; they will always be

I'm talking about ec2 module specifically instance_initiated_shutdown_behavior: "terminate" should accept value "stop" for spot instances
https://docs.ansible.com/ansible/latest/modules/ec2_module.html#parameter-instance_initiated_shutdown_behavior
@jeyrichman
Copy link
Author

Hello, any news on this?

@ansibullbot
Copy link

@Raboy: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot ansibullbot added affects_2.10 feature This issue/PR relates to a feature request needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage labels Aug 19, 2020
@goneri goneri added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels Dec 4, 2020
@goneri
Copy link
Member

goneri commented Dec 4, 2020

Thank you for the feature request. We would actually prefer to see a feature like that in ec2_instance, but spot support need to be implemented first.
This being said, if you submit a fix for ec2.py, we would merge it.

@ansibullbot ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels Jan 13, 2021
@ansibullbot
Copy link

@Raboy This issue is waiting for your response. Please respond or the issue will be closed.

click here for bot help

@alinabuzachis
Copy link
Collaborator

@jillr is this something we plan to implement in the new spot module?

@ansibullbot
Copy link

@Raboy You have not responded to information requests in this issue so we will assume it no longer affects you. If you are still interested in this, please create a new issue with the requested information.

click here for bot help

abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@wimnat
Update documentation for security_groups parameter (ansible-collectio…
c94200b 
…ns#61)

Clarified documentation surrounding using security_groups for any VPC other than Default.
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@wimnat @abikouo
Update documentation for security_groups parameter (ansible-collectio…
ea234e0 
…ns#61)

Clarified documentation surrounding using security_groups for any VPC other than Default.
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@wimnat
Update documentation for security_groups parameter (ansible-collectio…
25b9661 
…ns#61)

Clarified documentation surrounding using security_groups for any VPC other than Default.
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 18, 2024
@wimnat @abikouo
Update documentation for security_groups parameter (ansible-collectio…
997b190 
…ns#61)

Clarified documentation surrounding using security_groups for any VPC other than Default.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@25b9661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects_2.10 backlog feature This issue/PR relates to a feature request needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly spot waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goneri @jeyrichman @alinabuzachis @ansibullbot