ec2_vpc_igw creates a detached igw and fails if the vpc_id supplied does not exist

[branic]

Summary

When trying to create an internet gateway and supplying an incorrect vpc_id an internet gateway is created, but the module fails when trying to attach to the VPC.

Issue Type

Bug Report

Component Name

ec2_vpc_igw

Ansible Version

$ ansible --version
ansible [core 2.15.4]
  config file = None
  configured module search path = ['/home/bevans/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/bevans/.local/lib/python3.11/site-packages/ansible
  ansible collection location = /home/bevans/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/bevans/.local/bin/ansible
  python version = 3.11.5 (main, Aug 28 2023, 00:00:00) [GCC 13.2.1 20230728 (Red Hat 13.2.1-1)] (/usr/bin/python3)
  jinja version = 3.0.3
  libyaml = True

Collection Versions

$ ansible-galaxy collection list

# /usr/share/ansible/collections/ansible_collections
Collection    Version
------------- -------
amazon.aws    6.4.0  
community.aws 6.3.0  

AWS SDK versions

$ pip show boto boto3 botocore
WARNING: Package(s) not found: boto
Name: boto3
Version: 1.28.59
Summary: The AWS SDK for Python
Home-page: https://github.com/boto/boto3
Author: Amazon Web Services
Author-email: 
License: Apache License 2.0
Location: /usr/local/lib/python3.9/site-packages
Requires: botocore, jmespath, s3transfer
Required-by: 
---
Name: botocore
Version: 1.31.59
Summary: Low-level, data-driven core of boto 3.
Home-page: https://github.com/boto/botocore
Author: Amazon Web Services
Author-email: 
License: Apache License 2.0
Location: /usr/local/lib/python3.9/site-packages
Requires: jmespath, python-dateutil, urllib3
Required-by: boto3, s3transfer

Configuration

$ ansible-config dump --only-changed
CONFIG_FILE() = /etc/ansible/ansible.cfg

OS / Environment

Red Hat Enterprise Linux release 8.8 (Ootpa)

Steps to Reproduce

    - name: Create IGW
      amazon.aws.ec2_vpc_igw:
        vpc_id: vpc-abcdefgh
        state: present
      register: igw_result

Expected Results

Expected module to fail with an error that the VPC could not be found to attach the internet gateway to and not leave a detached gateway created.

Actual Results

The module failed, but a detached internet gateway was left in the AWS account.

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[branic]

I plan on working on a PR to fix this behavior.

[branic]

Closing issue as this was fixed with #1786