-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placement/availability-zone-id as a hostvar #1550
Labels
feature
This issue/PR relates to a feature request
has_pr
waiting_on_contributor
Needs help. Feel free to engage to get things unblocked
Comments
gravesm
added
waiting_on_contributor
Needs help. Feel free to engage to get things unblocked
and removed
needs_triage
labels
May 16, 2023
Files identified in the description:
If these files are inaccurate, please update the |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Sep 18, 2023
…s in check mode (ansible-collections#1550) ecs_ecr - Fix `RepositoryNotFoundException` when creating Repositories in check mode SUMMARY When trying to create a repository in check mode the module throws a RepositoryNotFoundException trying to access policy objects on the repositories also fixes and re-enables basic integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_ecr ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Sep 18, 2023
…llections#1551) ecs_ecr - Use compare_policies instead of naive dict sort Depends-On: ansible-collections#1550 SUMMARY When comparing policies on the repos ecs_ecr currently uses a very naive sort function. Since we have something more comprehensive, use it. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ecs_ecr.py ADDITIONAL INFORMATION ecs_ecr is currently the only module using sort_json_policy_dict and it has poor test coverage. Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Sep 18, 2023
…s in check mode (ansible-collections#1550) ecs_ecr - Fix `RepositoryNotFoundException` when creating Repositories in check mode SUMMARY When trying to create a repository in check mode the module throws a RepositoryNotFoundException trying to access policy objects on the repositories also fixes and re-enables basic integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_ecr ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Sep 18, 2023
…llections#1551) ecs_ecr - Use compare_policies instead of naive dict sort Depends-On: ansible-collections#1550 SUMMARY When comparing policies on the repos ecs_ecr currently uses a very naive sort function. Since we have something more comprehensive, use it. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ecs_ecr.py ADDITIONAL INFORMATION ecs_ecr is currently the only module using sort_json_policy_dict and it has poor test coverage. Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Oct 24, 2023
…s in check mode (ansible-collections#1550) ecs_ecr - Fix `RepositoryNotFoundException` when creating Repositories in check mode SUMMARY When trying to create a repository in check mode the module throws a RepositoryNotFoundException trying to access policy objects on the repositories also fixes and re-enables basic integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_ecr ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Oct 24, 2023
…llections#1551) ecs_ecr - Use compare_policies instead of naive dict sort Depends-On: ansible-collections#1550 SUMMARY When comparing policies on the repos ecs_ecr currently uses a very naive sort function. Since we have something more comprehensive, use it. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ecs_ecr.py ADDITIONAL INFORMATION ecs_ecr is currently the only module using sort_json_policy_dict and it has poor test coverage. Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
This issue/PR relates to a feature request
has_pr
waiting_on_contributor
Needs help. Feel free to engage to get things unblocked
Summary
It would be nice to have availability-zone-id available in the hostvars. Right now only availability_zone is available, storing AZ name.
Main use case is to use it in different topology-aware configurations when having services in different AWS accounts. E.g. we have a kafka cluster in one AWS account, consumers are in a different one. According to AWS documentation AZ names may be mapped to different physical locations in order to have a more even load spread. It would be much easier to perform a proper configuration if we have this AZ ID in hostvars, instead of getting it from EC2 metadata directly in ansible tasks.
It can be found using describe_availability_zones from Boto3.
Issue Type
Feature Idea
Component Name
plugins/inventory/aws_ec2.py
Additional Information
Code of Conduct
The text was updated successfully, but these errors were encountered: