ec2_security_group - exception when group_name or group_id is a list

[tremble]

Summary

Working on #1214 I've uncovered that --diff will throw an exception if group_name or group_id is a list:

2022-10-27 11:58:03.617055 | controller | TASK [ec2_security_group : Create a group with self-referring rule] ************
2022-10-27 11:58:03.617058 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/ec2_security_group/tasks/rule_group_create.yml:3
2022-10-27 11:58:08.598925 | controller | Using module file /home/zuul/.ansible/collections/ansible_collections/amazon/aws/plugins/modules/ec2_security_group.py
2022-10-27 11:58:08.598976 | controller | Pipelining is enabled.
2022-10-27 11:58:08.598983 | controller | <testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul
2022-10-27 11:58:08.598988 | controller | <testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /home/zuul/venv/bin/python && sleep 0'
2022-10-27 11:58:08.598993 | controller | The full traceback is:
2022-10-27 11:58:08.598997 | controller | Traceback (most recent call last):
2022-10-27 11:58:08.599007 | controller |   File "/tmp/ansible_ec2_security_group_payload_7_o0can2/ansible_ec2_security_group_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_security_group.py", line 1120, in group_exists
2022-10-27 11:58:08.599013 | controller |   File "/tmp/ansible_ec2_security_group_payload_7_o0can2/ansible_ec2_security_group_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_security_group.py", line 676, in sg_exists_with_backoff
2022-10-27 11:58:08.599018 | controller |   File "/tmp/ansible_ec2_security_group_payload_7_o0can2/ansible_ec2_security_group_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/modules.py", line 354, in deciding_wrapper
2022-10-27 11:58:08.599023 | controller |     return retrying_wrapper(*args, **kwargs)
2022-10-27 11:58:08.599027 | controller |   File "/tmp/ansible_ec2_security_group_payload_7_o0can2/ansible_ec2_security_group_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/cloud.py", line 118, in _retry_wrapper
2022-10-27 11:58:08.599032 | controller |     return _retry_func(
2022-10-27 11:58:08.599036 | controller |   File "/tmp/ansible_ec2_security_group_payload_7_o0can2/ansible_ec2_security_group_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/cloud.py", line 68, in _retry_func
2022-10-27 11:58:08.599040 | controller |     return func()
2022-10-27 11:58:08.599045 | controller |   File "/home/zuul/venv/lib/python3.9/site-packages/botocore/client.py", line 386, in _api_call
2022-10-27 11:58:08.599049 | controller |     return self._make_api_call(operation_name, kwargs)
2022-10-27 11:58:08.599053 | controller |   File "/home/zuul/venv/lib/python3.9/site-packages/botocore/client.py", line 677, in _make_api_call
2022-10-27 11:58:08.599061 | controller |     request_dict = self._convert_to_request_dict(
2022-10-27 11:58:08.599066 | controller |   File "/home/zuul/venv/lib/python3.9/site-packages/botocore/client.py", line 725, in _convert_to_request_dict
2022-10-27 11:58:08.599071 | controller |     request_dict = self._serializer.serialize_to_request(
2022-10-27 11:58:08.599076 | controller |   File "/home/zuul/venv/lib/python3.9/site-packages/botocore/validate.py", line 319, in serialize_to_request
2022-10-27 11:58:08.599080 | controller |     raise ParamValidationError(report=report.generate_report())
2022-10-27 11:58:08.599084 | controller | botocore.exceptions.ParamValidationError: Parameter validation failed:
2022-10-27 11:58:08.599089 | controller | Invalid type for parameter Filters[0].Values[0], value: ['ansible-test-72084338-node-0003193695-auto-create-1'], type: <class 'list'>, valid types: <class 'str'>
2022-10-27 11:58:08.599094 | controller | fatal: [testhost]: FAILED! => {

Issue Type

Bug Report

Component Name

ec2_security_group

Ansible Version

CI

Collection Versions

CI / 5.0.0

AWS SDK versions

CI

Configuration

CI

OS / Environment

CI

Steps to Reproduce

Pass group_name as a list

Expected Results

successful execution

Actual Results

Exception as above

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibullbot]

Files identified in the description:

• [plugins/modules/ec2_security_group.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/ec2_security_group.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @Razique @adq @jillr @s-hertel
click here for bot help