route53 module_utils not ported to amazon.aws #1064
Comments
|
CC: @alinabuzachis |
ansibullbot
added
bug
|
@tremble I guess we can close this one now. |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Sep 18, 2023
…s#1064) ec2_asg: Change purge_tags default value to False SUMMARY Changed default value of purge_tags to False. With the addition of purge_tags to ec2_asg module ansible-collections#960, the default value was kept to True similar to many other modules in this collection and also as specified in ansible dev guide. With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify purge_tags: false where required. This PR's change will prevent accidental breakage. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_asg Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Sep 18, 2023
…s#1064) ec2_asg: Change purge_tags default value to False SUMMARY Changed default value of purge_tags to False. With the addition of purge_tags to ec2_asg module ansible-collections#960, the default value was kept to True similar to many other modules in this collection and also as specified in ansible dev guide. With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify purge_tags: false where required. This PR's change will prevent accidental breakage. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_asg Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Oct 24, 2023
…s#1064) ec2_asg: Change purge_tags default value to False SUMMARY Changed default value of purge_tags to False. With the addition of purge_tags to ec2_asg module ansible-collections#960, the default value was kept to True similar to many other modules in this collection and also as specified in ansible dev guide. With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify purge_tags: false where required. This PR's change will prevent accidental breakage. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_asg Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
https://b7d126e9ce1bb4ebcac2-5137bb838e27bff384ce99c5e92105c7.ssl.cf1.rackcdn.com/1063/8671cbbc48875c782c9090a1de56ba527fe9248e/check/ansible-test-sanity-aws-ansible-2.12-python38/2184f29/job-output.txt
Issue Type
Bug Report
Component Name
route53
Ansible Version
CI
Collection Versions
Devel
AWS SDK versions
n/a
Configuration
n/a
OS / Environment
CI
Steps to Reproduce
Run sanity tests against devel
Expected Results
Tests pass
Actual Results
ERROR: plugins/modules/route53_health_check.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible_collections.community.aws.plugins.module_utils.route53''Code of Conduct
The text was updated successfully, but these errors were encountered: