-
Notifications
You must be signed in to change notification settings - Fork 342
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test/s3: keep the buck name lenght under control
The bucket_name variable length is 63 or below. If we add a prefix we can generate an invalid bucket name. In addition, the test has little value since it just ensures end-point behaves as expected. The code coverage in the module itself remains the same. See: https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html
- Loading branch information
Showing
2 changed files
with
1 addition
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/integration/targets/s3_bucket/roles/s3_bucket/defaults/main.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
--- | ||
bucket_name: '{{ resource_prefix }}-{{ inventory_hostname | regex_replace("_","-") }}' | ||
bucket_name: '{{ resource_prefix }}' |