Skip to content

Commit

Permalink
[stable-5] aws_rds - RDS inventory plugin didn't read config (#1332)
Browse files Browse the repository at this point in the history
[stable-5] aws_rds - RDS inventory plugin didn't read config

SUMMARY
fixes #1304
Partial reversion of #958 (ish)
_read_config_data() has side effects, namely that it sets all of the options data,  as well as returning data.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
aws_rds
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
  • Loading branch information
tremble authored Jan 10, 2023
1 parent b86ea0f commit 24997e1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/1304-aws_rds-config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- aws_rds - fixes bug in RDS inventory plugin where config file was ignored (https://github.com/ansible-collections/amazon.aws/issues/1304).
1 change: 1 addition & 0 deletions plugins/inventory/aws_rds.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ def parse(self, inventory, loader, path, cache=True):
if not HAS_BOTO3:
raise AnsibleError(missing_required_lib('botocore and boto3'))

self._read_config_data(path)
self._set_credentials()

# get user specifications
Expand Down

0 comments on commit 24997e1

Please sign in to comment.