Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint for direct submission of Ethereum events #294

Merged

Conversation

james-chf
Copy link
Contributor

@james-chf james-chf commented Aug 8, 2022

Closes #227

When the namada_apps/eth-fullnode feature is not enabled, there is a config option - ledger.ethereum.oracle_event_endpoint - which if set to true, makes it so that a server is started by the oracle exposing an endpoint at http://127.0.0.1:3030 for submission of Borsh-serialized EthereumEvents. Any events submitted there will be included in validator's vote extensions.

Enabling this functionality at runtime can be done like so:

ANOMA_LEDGER__ETHEREUM__ORACLE_EVENT_ENDPOINT=true target/debug/namadan ledger run

This functionality can be tested out using a devtool built from anoma/devtool#2

devtool submit-fake-transfer-to-namada \
	--nonce 1 \
	--receiver atest1v4ehgw36x5myzdfcg5myg3feg4p5vvzyxfrrgdpnxccnvvp5gdrrqse3gdz5zv2yxsenqs3ntgy89n

@james-chf james-chf force-pushed the james/ethbridge/eth-event-endpoint branch from e34fba1 to 0e876ab Compare August 11, 2022 15:03
@james-chf james-chf force-pushed the james/ethbridge/eth-event-endpoint branch from 0e876ab to ad422c8 Compare August 30, 2022 11:12
@james-chf james-chf force-pushed the james/ethbridge/eth-event-endpoint branch from ad422c8 to cd6ebeb Compare August 30, 2022 14:44
@james-chf james-chf force-pushed the james/ethbridge/eth-event-endpoint branch from cd6ebeb to c92ecb1 Compare September 2, 2022 09:13
@james-chf james-chf changed the base branch from eth-bridge-integration to james/ethbridge/configuration September 2, 2022 09:37
@james-chf james-chf force-pushed the james/ethbridge/eth-event-endpoint branch 2 times, most recently from 8fe01cd to 1cf052c Compare September 2, 2022 15:39
@james-chf james-chf changed the title Add endpoint for submission of test Ethereum events Add endpoint for direct submission of Ethereum events Sep 2, 2022
@james-chf james-chf marked this pull request as ready for review September 2, 2022 15:47
Base automatically changed from james/ethbridge/configuration to eth-bridge-integration September 4, 2022 11:07
Copy link
Contributor

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

apps/src/lib/config/ethereum.rs Outdated Show resolved Hide resolved
@james-chf james-chf force-pushed the james/ethbridge/eth-event-endpoint branch from 1cf052c to d64cf3c Compare September 5, 2022 08:37
Copy link
Member

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question, but otherwise looks good

apps/src/lib/config/ethereum.rs Show resolved Hide resolved
@james-chf james-chf force-pushed the james/ethbridge/eth-event-endpoint branch from d64cf3c to fd243f2 Compare September 6, 2022 09:12
@james-chf james-chf merged commit 9f046da into eth-bridge-integration Sep 6, 2022
@james-chf james-chf deleted the james/ethbridge/eth-event-endpoint branch September 6, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants