-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint for direct submission of Ethereum events #294
Merged
james-chf
merged 3 commits into
eth-bridge-integration
from
james/ethbridge/eth-event-endpoint
Sep 6, 2022
Merged
Add endpoint for direct submission of Ethereum events #294
james-chf
merged 3 commits into
eth-bridge-integration
from
james/ethbridge/eth-event-endpoint
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-chf
force-pushed
the
james/ethbridge/eth-event-endpoint
branch
from
August 11, 2022 15:03
e34fba1
to
0e876ab
Compare
james-chf
force-pushed
the
james/ethbridge/eth-event-endpoint
branch
from
August 30, 2022 11:12
0e876ab
to
ad422c8
Compare
james-chf
force-pushed
the
james/ethbridge/eth-event-endpoint
branch
from
August 30, 2022 14:44
ad422c8
to
cd6ebeb
Compare
james-chf
force-pushed
the
james/ethbridge/eth-event-endpoint
branch
from
September 2, 2022 09:13
cd6ebeb
to
c92ecb1
Compare
james-chf
changed the base branch from
eth-bridge-integration
to
james/ethbridge/configuration
September 2, 2022 09:37
4 tasks
james-chf
force-pushed
the
james/ethbridge/eth-event-endpoint
branch
2 times, most recently
from
September 2, 2022 15:39
8fe01cd
to
1cf052c
Compare
james-chf
changed the title
Add endpoint for submission of test Ethereum events
Add endpoint for direct submission of Ethereum events
Sep 2, 2022
james-chf
force-pushed
the
james/ethbridge/configuration
branch
from
September 2, 2022 15:46
4663857
to
956ee9c
Compare
Base automatically changed from
james/ethbridge/configuration
to
eth-bridge-integration
September 4, 2022 11:07
sug0
approved these changes
Sep 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
james-chf
force-pushed
the
james/ethbridge/eth-event-endpoint
branch
from
September 5, 2022 08:37
1cf052c
to
d64cf3c
Compare
batconjurer
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question, but otherwise looks good
james-chf
force-pushed
the
james/ethbridge/eth-event-endpoint
branch
from
September 6, 2022 09:12
d64cf3c
to
fd243f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #227
When the
namada_apps/eth-fullnode
feature is not enabled, there is a config option -ledger.ethereum.oracle_event_endpoint
- which if set to true, makes it so that a server is started by the oracle exposing an endpoint athttp://127.0.0.1:3030
for submission of Borsh-serializedEthereumEvent
s. Any events submitted there will be included in validator's vote extensions.Enabling this functionality at runtime can be done like so:
This functionality can be tested out using a devtool built from anoma/devtool#2