Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping the toolchain version 1.76 #2687

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Bumping the toolchain version 1.76 #2687

merged 4 commits into from
Feb 27, 2024

Conversation

batconjurer
Copy link
Member

@batconjurer batconjurer commented Feb 21, 2024

Describe your changes

Moving to rust version 1.76.0

Indicate on which release or other PRs this topic is based on

0.31.6

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@batconjurer batconjurer marked this pull request as draft February 21, 2024 16:26
@Fraccaman
Copy link
Member

hvae u seen #2566 ?

@batconjurer
Copy link
Member Author

hvae u seen #2566 ?

Nope totally missed that. I needed these changes for something unrelated, so I decided to bang em out. This already has all the clippy fixes, I just need to check the tests locally

@tzemanovic tzemanovic mentioned this pull request Feb 22, 2024
2 tasks
@tzemanovic tzemanovic changed the title Bumping the toolchain version Bumping the toolchain version 1.76 Feb 22, 2024
@tzemanovic tzemanovic marked this pull request as ready for review February 22, 2024 12:39
@Fraccaman
Copy link
Member

we need to split docker changes into a separete PR and merge those before updating the toolchain

@tzemanovic
Copy link
Member

we need to split docker changes into a separete PR and merge those before updating the toolchain

done in #2696

tzemanovic
tzemanovic previously approved these changes Feb 22, 2024
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

crates/core/src/types/key/secp256k1.rs Outdated Show resolved Hide resolved
crates/macros/src/lib.rs Show resolved Hide resolved
@tzemanovic
Copy link
Member

I squashed the fixup commit and rebased onto 0.31.6

tzemanovic added a commit that referenced this pull request Feb 27, 2024
* bat/toochain-1.76.0:
  Update crates/core/src/types/key/secp256k1.rs
  ci+docker: update toolchain versions
  Fixed unit tests. Added changelog. Updated toolchain for wasm
  [feat]: Bumping the toolchain version
@tzemanovic tzemanovic merged commit b13c9f1 into main Feb 27, 2024
9 of 12 checks passed
@tzemanovic tzemanovic deleted the bat/toochain-1.76.0 branch February 27, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants