-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append unique hash to the pre-release tag in the Package.juvix version #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
hash-globalpkg
branch
3 times, most recently
from
December 3, 2024 11:46
b92b14e
to
1a1c40a
Compare
janmasrovira
changed the title
Insert hash to packages without pre-release annotation
Append unique hash to the pre-release tag in the Package.juvix version
Dec 3, 2024
janmasrovira
force-pushed
the
hash-globalpkg
branch
from
December 4, 2024 09:41
9353f4e
to
8c5db7e
Compare
This reverts commit 05bf219.
janmasrovira
force-pushed
the
hash-globalpkg
branch
from
December 4, 2024 11:05
8c5db7e
to
a7ec169
Compare
paulcadman
reviewed
Dec 5, 2024
commit 1a76df9 Author: Łukasz Czajka <[email protected]> Date: Thu Dec 5 14:12:21 2024 +0100 Fix RISC0 CI (#3233)
paulcadman
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the above issues by appending the hash of all project files in the package version. In particular, it appends the hash to the pre-release tag.
Also, when recursing in an import, we properly update the PackageId in the Entrypoint.